calendar updates, indexing by date, filtering#42
Open
naseerahkani wants to merge 1 commit into
Open
Conversation
Collaborator
|
Looks good looks good Only comment I have is that the events do not scroll down to the current day on page load. You can observe this if you go to the calendar page > pick date > today (july 15) and it will scroll properly. W filter button effects 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
indexing by date works, meaning that one can pick a date and events 30 days prior and 90 days after the chosen date will be displayed for efficiency
filtering by tag only works for specified time frame
one thing to note is that the home page displayed a fixed arbitrary date (nov 12) for now, but if needed, I can fix that to pull information from the actual calendar depending on what is needed
#37!