Skip to content

calendar updates, indexing by date, filtering#42

Open
naseerahkani wants to merge 1 commit into
mainfrom
naseerahkani/calendar
Open

calendar updates, indexing by date, filtering#42
naseerahkani wants to merge 1 commit into
mainfrom
naseerahkani/calendar

Conversation

@naseerahkani

Copy link
Copy Markdown
Collaborator

indexing by date works, meaning that one can pick a date and events 30 days prior and 90 days after the chosen date will be displayed for efficiency

filtering by tag only works for specified time frame

one thing to note is that the home page displayed a fixed arbitrary date (nov 12) for now, but if needed, I can fix that to pull information from the actual calendar depending on what is needed

#37!

@aryavenkatesan aryavenkatesan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aryavenkatesan

Copy link
Copy Markdown
Collaborator

Looks good looks good

Only comment I have is that the events do not scroll down to the current day on page load. You can observe this if you go to the calendar page > pick date > today (july 15) and it will scroll properly.
It seems like that feature works properly, so you'll just have to add one thing at the beginning of the widget lifecycle after events are loaded.

W filter button effects 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants