RLC Rebase prep: testing fixups by PlaidCat · Pull Request #76 · ctrliq/kernel-src-tree-tools

PlaidCat · 2026-06-25T14:12:32Z

As a part of moving RLC Rebases off my laptop into this repo and mainline I wanted to improve our testing and test reporting updates.

This fixes the current tests, adds shell check to the precommits and adds test coverage to the PRs.

This will also be a test for the PR adding test coverage update process.

Local coverage

(venv311) [jmaple@devbox kernel-src-tree-tools]$ pytest --cov
.....................                                                                        [100%]
========================================== tests coverage ==========================================
_________________________ coverage: platform linux, python 3.11.13-final-0 _________________________

Name                        Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------
check_fips_changes.py          42     42     12      0     0%   8-67
check_kernel_commits.py       179    179     76      0     0%   3-371
ciq-cherry-pick.py            190    190     50      0     0%   1-426
ciq-tag.py                    146    146     16      0     0%   3-378
ciq_tag.py                    232    232     54      0     0%   1-464
jira_pr_check.py              180    180     80      0     0%   3-381
kt/ktlib/config.py             47      4      8      2    89%   52, 82-85
kt/ktlib/kernels.py            76     16     12      2    77%   51-59, 76-78, 108, 124-131
kt/ktlib/repo.py               29     15      2      0    45%   30-31, 34-35, 43-55
kt/ktlib/util.py               14      0      0      0   100%
release_config.py               2      2      0      0     0%   7-27
rolling-release-update.py     264    264    106      0     0%   1-412
run_interdiff.py              165    165     56      0     0%   3-244
update_lt_spec.py             219    219     46      0     0%   9-411
-----------------------------------------------------------------------
TOTAL                        1785   1654    518      4     6%
21 passed in 0.26s

If this works a test coverage will be updated below here

I guess we need it on the main branch as dispatch is not helping me here
The workflow has the execution and upload though
https://github.com/ctrliq/kernel-src-tree-tools/actions/runs/28176418390/job/83453900019?pr=76#step:7:34

These tests were not updated and are failing. RLC rebase will be expanding test coverage but these needed fixed.

Copilot

Pull request overview

This PR prepares the repo for RLC rebase work by fixing/adjusting existing tests and improving CI quality gates and reporting, including automated coverage reporting back into PRs.

Changes:

Update ktlib tests to reflect required config/kernel fields (e.g., user, mock_config, automated).
Add pytest-cov plus pytest/coverage configuration to standardize test and coverage behavior.
Extend PR CI to run tests with coverage, upload the report as an artifact, and add a follow-up workflow to post coverage into the PR body.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`tests/kt/ktlib/test_kernels.py`	Updates test kernel fixtures to include required kernel fields.
`tests/kt/ktlib/test_config.py`	Adds `user` to test config JSON and hardens default-load test against env leakage.
`pyproject.toml`	Adds pytest-cov and configures pytest + coverage reporting defaults.
`ciq_tag.py`	Minor lambda cleanup in tag insertion logic.
`.pre-commit-config.yaml`	Pins ruff hook by SHA and adds shellcheck pre-commit hook.
`.github/workflows/pr_check.yml`	Adds pytest+coverage execution and uploads the coverage artifact/PR metadata artifacts.
`.github/workflows/pr_check_comment.yml`	New workflow_run job to download artifacts and append coverage to the PR body.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

bmastbergen

Couple of little things. Otherwise, LGTM

Added shellcheck to the precommit. WIWT: Pinned ruff-pre-commit to latest in the format SRE has been doing with GitHub Actions. Update caused changed and included that change.

Initial point to add in coverage reporting and updating the PR on workflow execution.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

+      - name: Checksum PR Metadata
+        if: github.event_name == 'pull_request'
+        run: |
+          mkdir -p pr_metadata
+          cd pr_metadata && sha256sum *.txt > checksums.txt
+


+        uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
+        with:
+          name: coverage-report
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          run-id: ${{ github.event_name == 'workflow_dispatch' && inputs.run_id || github.event.workflow_run.id }}


+        uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
+        with:
+          name: pr-metadata
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          run-id: ${{ github.event_name == 'workflow_dispatch' && inputs.run_id || github.event.workflow_run.id }}


+      - name: Read and Validate PR number
+        id: pr_number
+        env:
+          PR_NUMBER: ${{ github.event.workflow_run.pull_requests[0].number }}
+        run: |
+          if [ -z "$PR_NUMBER" ] || ! [[ "$PR_NUMBER" =~ ^[0-9]+$ ]]; then
+            echo "Error: Could not determine PR number from workflow_run payload: $PR_NUMBER"
+            exit 1
+          fi
+          echo "PR_NUMBER=$PR_NUMBER" >> "$GITHUB_OUTPUT"
+      - name: Validate coverage report


bmastbergen

🥌

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

+      - name: Checksum PR Metadata
+        if: github.event_name == 'pull_request'
+        run: |
+          mkdir -p pr_metadata
+          cd pr_metadata && sha256sum *.txt > checksums.txt
+


+      - name: Read and Validate PR number
+        id: pr_number
+        env:
+          PR_NUMBER: ${{ github.event.workflow_run.pull_requests[0].number }}
+        run: |
+          if [ -z "$PR_NUMBER" ] || ! [[ "$PR_NUMBER" =~ ^[0-9]+$ ]]; then
+            echo "Error: Could not determine PR number from workflow_run payload: $PR_NUMBER"
+            exit 1
+          fi
+          echo "PR_NUMBER=$PR_NUMBER" >> "$GITHUB_OUTPUT"
+      - name: Validate coverage report


[Testing] Fix up current tests for future work

03f6754

These tests were not updated and are failing. RLC rebase will be expanding test coverage but these needed fixed.

PlaidCat self-assigned this Jun 25, 2026

Copilot AI review requested due to automatic review settings June 25, 2026 14:12

Copilot started reviewing on behalf of PlaidCat June 25, 2026 14:13 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread .github/workflows/pr_check_comment.yml Outdated

Comment thread ciq_tag.py Outdated

Copilot AI review requested due to automatic review settings June 25, 2026 14:17

Copilot started reviewing on behalf of PlaidCat June 25, 2026 14:17 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 25, 2026 15:08

Copilot started reviewing on behalf of PlaidCat June 25, 2026 15:09 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread .github/workflows/pr_check_comment.yml Outdated

Comment thread .github/workflows/pr_check_comment.yml

Comment thread .github/workflows/pr_check_comment.yml

Comment thread .github/workflows/pr_check.yml

Comment thread .github/workflows/pr_check_comment.yml

Copilot AI review requested due to automatic review settings June 25, 2026 15:14

PlaidCat force-pushed the {jmaple}_rlc_rebase_testing branch from 7d79827 to 76c5d3e Compare June 25, 2026 15:14

Copilot started reviewing on behalf of PlaidCat June 25, 2026 15:14 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread pyproject.toml

Comment thread .github/workflows/pr_check_comment.yml Outdated

Comment thread .github/workflows/pr_check_comment.yml

PlaidCat requested review from bmastbergen, kerneltoast, roxanan1996 and shreeya-patel98 June 25, 2026 15:24

PlaidCat force-pushed the {jmaple}_rlc_rebase_testing branch from 76c5d3e to 7fb6872 Compare June 25, 2026 15:42

PlaidCat requested a review from Copilot June 25, 2026 16:03

Copilot started reviewing on behalf of PlaidCat June 25, 2026 16:04 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread .github/workflows/pr_check_comment.yml

Comment thread .github/workflows/pr_check_comment.yml

PlaidCat force-pushed the {jmaple}_rlc_rebase_testing branch 2 times, most recently from 73b5de3 to d13a9f1 Compare June 25, 2026 18:08

bmastbergen reviewed Jun 25, 2026

View reviewed changes

Comment thread .pre-commit-config.yaml Outdated

Comment thread .github/workflows/pr_check.yml Outdated

PlaidCat added 2 commits June 25, 2026 17:15

[Pre-Commit] Add shell check and pin to shas

d0a7b3a

Added shellcheck to the precommit. WIWT: Pinned ruff-pre-commit to latest in the format SRE has been doing with GitHub Actions. Update caused changed and included that change.

[Testing] Add in Coverage Reporting to tests

977ad4c

Initial point to add in coverage reporting and updating the PR on workflow execution.

Copilot AI review requested due to automatic review settings June 25, 2026 21:16

PlaidCat force-pushed the {jmaple}_rlc_rebase_testing branch from d13a9f1 to 977ad4c Compare June 25, 2026 21:16

Copilot started reviewing on behalf of PlaidCat June 25, 2026 21:16 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

bmastbergen requested review from bmastbergen and Copilot June 25, 2026 21:28

Copilot started reviewing on behalf of bmastbergen June 25, 2026 21:29 View session

bmastbergen approved these changes Jun 25, 2026

View reviewed changes

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Uh oh!

Conversation

PlaidCat commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Local coverage

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

bmastbergen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

bmastbergen left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

PlaidCat commented Jun 25, 2026 •

edited

Loading