Feedback docker#349
Open
4-dash wants to merge 11 commits into
Open
Conversation
4-dash
commented
May 22, 2025
4-dash
commented
Member
- Added docker file, docker-compose.
- some changes to settings
- renamed and modified django.wsgi to wsgi.py
- removed binary translation files
4-dash
force-pushed
the
feedback_docker
branch
from
dc76bc0 to
3754db6
Compare
| EXPOSE 8000 | ||
|
|
||
| # start applicaiton with gunicorn | ||
| CMD ["sh", "-c", "gunicorn --bind 0.0.0.0:8000 --workers ${GUNICORN_WORKERS:-3} wsgi:application"] No newline at end of file |
Member
There was a problem hiding this comment.
move this to entrypoint maybe?
Comment on lines
+25
to
+28
| # install node_modules | ||
| COPY package*.json ./ | ||
| RUN npm i | ||
|
|
Member
There was a problem hiding this comment.
suggestion: install node dependencies in a new stage from the nodejs docker image, so no nodejs needs to be installed -> faster build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.