Skip to content

chore: promote dev to main — config v0.16.0 (Mantis #1221)#5

Merged
Snider merged 1 commit into
mainfrom
dev
Apr 30, 2026
Merged

chore: promote dev to main — config v0.16.0 (Mantis #1221)#5
Snider merged 1 commit into
mainfrom
dev

Conversation

@Snider

@Snider Snider commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Brings v0.16.0 to main: refactor(go) using core.E + core.Result instead of the coreerr/log shim. Closes Mantis #1221.

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Service now properly handles CLI command registration failures instead of silently discarding them.
  • Documentation

    • Updated examples in feature documentation to reflect current printing conventions.

…antis #1221)

Drop the coreerr alias for dappco.re/go/log across the package — the
coreerr.E wrapper just forwarded to core.E. Calling core.E directly
removes a layer of indirection and matches the canonical core/go
primitive surface.

Also tighten Service.OnStartup to propagate registerCommands failures
via Result instead of discarding them silently, and update a stale
filepath.Join example in the manifest docstring to core.PathJoin.

No exported API changes. Build / vet / test all clean.

Closes tasks.lthn.sh/view.php?id=1221

Co-authored-by: Codex <noreply@openai.com>
@Snider Snider merged commit 02843fd into main Apr 30, 2026
2 of 5 checks passed
@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 76e0f755-08cc-4033-a53f-cf31e82a1d99

📥 Commits

Reviewing files that changed from the base of the PR and between 1b26481 and 572afdd.

📒 Files selected for processing (11)
  • go/conclave.go
  • go/config.go
  • go/discover.go
  • go/feature.go
  • go/images_manifest.go
  • go/manifest.go
  • go/resolve.go
  • go/schema.go
  • go/service.go
  • go/test_detect.go
  • go/watch.go

📝 Walkthrough

Walkthrough

This pull request removes the dappco.re/go/log error-wrapping helper dependency across all Go source files by replacing coreerr.E(...) with core.E(...) for error construction. One functional change makes registerCommands return core.Result. Documentation examples are updated to reference core.Println instead of fmt.Println.

Changes

Cohort / File(s) Summary
Error Constructor Migration
go/conclave.go, go/config.go, go/discover.go, go/images_manifest.go, go/manifest.go, go/resolve.go, go/schema.go, go/test_detect.go, go/watch.go
Removes coreerr import and replaces all coreerr.E(...) error construction with core.E(...) throughout failure paths. Error messages and wrapped causes remain unchanged.
Service Error Handling Enhancement
go/service.go
Updates registerCommands to return core.Result instead of discarding command registration outcomes. OnStartup now returns early on registration failure. Error construction switched from coreerr.E(...) to core.E(...). New callerServiceRegisterCommands constant added for error tagging.
Documentation Example Update
go/feature.go
Updates commented example in Features() documentation to use core.Println(flag) instead of fmt.Println(flag). No functional changes.

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant