Skip to content

fix: bump Go to 1.25.12 to resolve GO-2026-5856#54

Merged
dacrab merged 1 commit into
mainfrom
fix/go-1.25.12-GO-2026-5856
Jul 12, 2026
Merged

fix: bump Go to 1.25.12 to resolve GO-2026-5856#54
dacrab merged 1 commit into
mainfrom
fix/go-1.25.12-GO-2026-5856

Conversation

@dacrab

@dacrab dacrab commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Summary

The scheduled Security workflow (govulncheck) failed on main (run #29181607793) due to:

  • GO-2026-5856 — Encrypted Client Hello privacy leak in crypto/tls
    • Found in: crypto/tls@go1.25.11
    • Fixed in: crypto/tls@go1.25.12

This was introduced by the patch-level Go toolchain pinned via go.mod (go 1.25.11). Bumping to go 1.25.12 resolves the advisory.

Verification

  • go mod tidy succeeds.
  • govulncheck ./... reports: No vulnerabilities found.

Note

The Security workflow only runs on push to main / schedule, so it won't re-run on this PR. After merge, trigger it manually (workflow_dispatch) or wait for the weekly schedule to confirm the alert clears.

Summary by CodeRabbit

  • Chores
    • Updated the Go toolchain version to 1.25.12.

Update toolchain from go1.25.11 to go1.25.12 to address
GO-2026-5856 (Encrypted Client Hello privacy leak in crypto/tls),
which is fixed in crypto/tls@go1.25.12.
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c17a0d0b-cd86-46fd-bf28-6500a4933c5b

📥 Commits

Reviewing files that changed from the base of the PR and between f4e3e7a and b78d17a.

📒 Files selected for processing (1)
  • go.mod

📝 Walkthrough

Walkthrough

The module’s Go toolchain directive in go.mod was updated from version 1.25.11 to 1.25.12. No dependencies or other module metadata changed.

Changes

Go toolchain update

Layer / File(s) Summary
Update Go version directive
go.mod
The module’s go directive changes from 1.25.11 to 1.25.12.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: bumping the Go toolchain to 1.25.12 to address GO-2026-5856.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/go-1.25.12-GO-2026-5856

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dacrab
dacrab merged commit 4455123 into main Jul 12, 2026
7 checks passed
@dacrab
dacrab deleted the fix/go-1.25.12-GO-2026-5856 branch July 12, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant