fix: bump Go to 1.25.12 to resolve GO-2026-5856#54
Merged
Conversation
Update toolchain from go1.25.11 to go1.25.12 to address GO-2026-5856 (Encrypted Client Hello privacy leak in crypto/tls), which is fixed in crypto/tls@go1.25.12.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe module’s Go toolchain directive in ChangesGo toolchain update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scheduled Security workflow (govulncheck) failed on main (run #29181607793) due to:
This was introduced by the patch-level Go toolchain pinned via go.mod (go 1.25.11). Bumping to go 1.25.12 resolves the advisory.
Verification
Note
The Security workflow only runs on push to main / schedule, so it won't re-run on this PR. After merge, trigger it manually (workflow_dispatch) or wait for the weekly schedule to confirm the alert clears.
Summary by CodeRabbit