fix: update version codes and names in build.gradle and project.pbxproj; adjust URL handling in home.page.ts - #45
Open
damiant wants to merge 3 commits into
Open
fix: update version codes and names in build.gradle and project.pbxproj; adjust URL handling in home.page.ts#45damiant wants to merge 3 commits into
damiant wants to merge 3 commits into
Conversation
…oj; adjust URL handling in home.page.ts
Deploying webnative-qr-sdk with
|
| Latest commit: |
b4f3938
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0610a6d4.webnative-app.pages.dev |
| Branch Preview URL: | https://https-option.webnative-app.pages.dev |
Deploying webnative-app with
|
| Latest commit: |
b4f3938
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ccad7711.webnative-app-2ic.pages.dev |
| Branch Preview URL: | https://https-option.webnative-app-2ic.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR bumps Android/iOS build versions to 1.38/47 and updates the Home page’s URL normalization so manual entries can preserve “secure” (https) handling when converting inputs into a full URL.
Changes:
- Update Android
versionCode/versionNameand iOSCURRENT_PROJECT_VERSION/MARKETING_VERSIONto 47 / 1.38. - Adjust
HomePage.connect()to pass a “secure” hint intoHistoryService.toFullUrl(...). - Add a 1.38 changelog entry describing the https/manual-entry behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/app/home/home.page.ts |
Passes a derived “secure” flag into URL normalization when connecting to a user-entered URL. |
ios/App/App.xcodeproj/project.pbxproj |
Bumps iOS build and marketing versions. |
android/app/build.gradle |
Bumps Android version code/name. |
CHANGELOG.md |
Documents the 1.38 change. |
Comment on lines
167
to
+169
| const urlValue = url || this.urlForm.get('url')?.value || ''; | ||
| const fullUrl = this.historyService.toFullUrl(urlValue); | ||
| const secure = urlValue.includes('https://'); | ||
| const fullUrl = this.historyService.toFullUrl(urlValue, secure); |
Contributor
There was a problem hiding this comment.
Fixed in b4f3938. Changed to urlValue.trim().toLowerCase().startsWith('https://') so it only matches the scheme at the start of the trimmed input and handles case variants like HTTPS://.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/damiant/webnative-app/sessions/2dd757a1-290b-48cd-ac67-764f3d1479f3 Co-authored-by: damiant <3505469+damiant@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.