Issue299 #342
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| [ | ||
| { | ||
| "fabricNode": { | ||
| "attributes": { | ||
| "adSt": "on", | ||
| "address": "10.1.72.70", | ||
| "annotation": "", | ||
| "apicType": "apic", | ||
| "childAction": "", | ||
| "delayedHeartbeat": "no", | ||
| "dn": "topology/pod-1/node-101", | ||
| "extMngdBy": "", | ||
| "fabricSt": "active", | ||
| "id": "101", | ||
| "lastStateModTs": "2026-01-21T14:24:21.952-05:00", | ||
| "lcOwn": "local", | ||
| "modTs": "2026-01-21T14:24:22.964-05:00", | ||
| "model": "N9K-C93180YC-EX", | ||
| "monPolDn": "uni/fabric/monfab-default", | ||
| "name": "leaf1", | ||
| "nameAlias": "", | ||
| "nodeType": "unspecified", | ||
| "role": "leaf", | ||
| "serial": "FDO221802B0", | ||
| "status": "", | ||
| "uid": "0", | ||
| "userdom": "all", | ||
| "vendor": "Cisco Systems, Inc", | ||
| "version": "n9000-16.0(9d)" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "fabricNode": { | ||
| "attributes": { | ||
| "adSt": "on", | ||
| "address": "10.1.72.71", | ||
| "annotation": "", | ||
| "apicType": "apic", | ||
| "childAction": "", | ||
| "delayedHeartbeat": "no", | ||
| "dn": "topology/pod-1/node-103", | ||
| "extMngdBy": "", | ||
| "fabricSt": "active", | ||
| "id": "103", | ||
| "lastStateModTs": "2026-01-20T19:37:36.258-05:00", | ||
| "lcOwn": "local", | ||
| "modTs": "2026-01-20T19:38:54.044-05:00", | ||
| "model": "N9K-C93180YC-EX", | ||
| "monPolDn": "uni/fabric/monfab-default", | ||
| "name": "leaf3", | ||
| "nameAlias": "", | ||
| "nodeType": "unspecified", | ||
| "role": "leaf", | ||
| "serial": "FDO22180284", | ||
| "status": "", | ||
| "uid": "0", | ||
| "userdom": "all", | ||
| "vendor": "Cisco Systems, Inc", | ||
| "version": "n9000-16.0(9d)" | ||
| } | ||
| } | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| [ | ||
| { | ||
| "fabricNode": { | ||
| "attributes": { | ||
| "adSt": "on", | ||
| "address": "10.1.72.70", | ||
| "annotation": "", | ||
| "apicType": "apic", | ||
| "childAction": "", | ||
| "delayedHeartbeat": "no", | ||
| "dn": "topology/pod-1/node-101", | ||
| "extMngdBy": "", | ||
| "fabricSt": "active", | ||
| "id": "101", | ||
| "lastStateModTs": "2026-01-21T14:24:21.952-05:00", | ||
| "lcOwn": "local", | ||
| "modTs": "2026-01-21T14:24:22.964-05:00", | ||
| "model": "N9K-C9316D-GX", | ||
| "monPolDn": "uni/fabric/monfab-default", | ||
| "name": "leaf1", | ||
| "nameAlias": "", | ||
| "nodeType": "unspecified", | ||
| "role": "leaf", | ||
| "serial": "FDO221802B0", | ||
| "status": "", | ||
| "uid": "0", | ||
| "userdom": "all", | ||
| "vendor": "Cisco Systems, Inc", | ||
| "version": "n9000-16.0(9d)" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "fabricNode": { | ||
| "attributes": { | ||
| "adSt": "on", | ||
| "address": "10.1.72.71", | ||
| "annotation": "", | ||
| "apicType": "apic", | ||
| "childAction": "", | ||
| "delayedHeartbeat": "no", | ||
| "dn": "topology/pod-1/node-103", | ||
| "extMngdBy": "", | ||
| "fabricSt": "active", | ||
| "id": "103", | ||
| "lastStateModTs": "2026-01-20T19:37:36.258-05:00", | ||
| "lcOwn": "local", | ||
| "modTs": "2026-01-20T19:38:54.044-05:00", | ||
| "model": "N9K-C93600CD-GX", | ||
| "monPolDn": "uni/fabric/monfab-default", | ||
| "name": "leaf3", | ||
| "nameAlias": "", | ||
| "nodeType": "unspecified", | ||
| "role": "leaf", | ||
| "serial": "FDO22180284", | ||
| "status": "", | ||
| "uid": "0", | ||
| "userdom": "all", | ||
| "vendor": "Cisco Systems, Inc", | ||
| "version": "n9000-16.0(9d)" | ||
| } | ||
| } | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,155 @@ | ||
| import os | ||
| import pytest | ||
| import logging | ||
| import importlib | ||
| from helpers.utils import read_data | ||
|
|
||
| script = importlib.import_module("aci-preupgrade-validation-script") | ||
|
|
||
| log = logging.getLogger(__name__) | ||
| dir = os.path.dirname(os.path.abspath(__file__)) | ||
|
|
||
| test_function = "gx_hw_changes_bit_check" | ||
|
|
||
| fabricNodes = read_data(dir, "fabricNode-Pos.json") | ||
| switch_ips = [ | ||
| mo["fabricNode"]["attributes"]["address"] | ||
| for mo in fabricNodes | ||
| if "-GX" in mo["fabricNode"]["attributes"]["model"] | ||
| ] | ||
|
|
||
| sprom_cmd = "vsh -c 'show sprom cpu-info' | grep 'HW Changes Bits'" | ||
| sprom_output_neg = " HW Changes Bits : 0x0" | ||
| sprom_output_pos = " HW Changes Bits : 0x3" | ||
|
|
||
| sprom_output_no_such_file = "" | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "icurl_outputs, fabric_nodes, cversion, tversion, conn_failure, conn_cmds, expected_result, expected_data", | ||
| [ | ||
| # NA, no fabricNode with affected models | ||
| ( | ||
| {}, | ||
| read_data(dir, "fabricNode-Neg.json"), | ||
| "4.2(3b)", | ||
| "4.2(4p)", | ||
| False, | ||
| [], | ||
| script.NA, | ||
| [], | ||
| ), | ||
| # NA, Versions not affected | ||
| ( | ||
| {}, | ||
| read_data(dir, "fabricNode-Neg.json"), | ||
| "4.2(5l)", | ||
| "6.0(1h)", | ||
| False, | ||
| [], | ||
| script.NA, | ||
| [], | ||
| ), | ||
| # NA, Versions not affected | ||
| ( | ||
| {}, | ||
| read_data(dir, "fabricNode-Neg.json"), | ||
| "4.2(1f)", | ||
| "5.2(7f)", | ||
| False, | ||
| [], | ||
| script.NA, | ||
| [], | ||
| ), | ||
| # Connection failure | ||
| ( | ||
| {}, | ||
| fabricNodes, | ||
| "4.2(3b)", | ||
| "4.2(4b)", | ||
| True, | ||
| [], | ||
| script.ERROR, | ||
| [ | ||
| ["101", "leaf1", "Simulated exception at connect()"], | ||
| ["103", "leaf3", "Simulated exception at connect()"], | ||
| ], | ||
| ), | ||
| # Simulated exception at `show sprom cpu-info` command | ||
| ( | ||
| {}, | ||
| fabricNodes, | ||
| "4.2(3b)", | ||
| "4.2(4p)", | ||
| False, | ||
| { | ||
| switch_ip: [ | ||
| { | ||
| "cmd": sprom_cmd, | ||
| "output": "", | ||
| "exception": Exception("Simulated exception at `vsh` command"), | ||
| } | ||
| ] | ||
| for switch_ip in switch_ips | ||
| }, | ||
| script.ERROR, | ||
| [ | ||
| ["101", "leaf1", "Simulated exception at `vsh` command"], | ||
| ["103", "leaf3", "Simulated exception at `vsh` command"], | ||
| ], | ||
| ), | ||
| # PASS Affected Models, cpu-info is correct (0x0) | ||
| ( | ||
| {}, | ||
| fabricNodes, | ||
| "4.2(3b)", | ||
| "4.2(4c)", | ||
| False, | ||
| { | ||
| switch_ip: [ | ||
| { | ||
| "cmd": sprom_cmd, | ||
| "output": "\n".join([sprom_cmd, sprom_output_neg]), | ||
| "exception": None, | ||
| } | ||
| ] | ||
| for switch_ip in switch_ips | ||
| }, | ||
| script.PASS, | ||
| [], | ||
| ), | ||
| # FAIL_UF Affected Models, cpu-info is incorrect (0x3) | ||
| ( | ||
| {}, | ||
| fabricNodes, | ||
| "4.2(3b)", | ||
| "4.2(4p)", | ||
| False, | ||
| { | ||
| switch_ip: [ | ||
| { | ||
| "cmd": sprom_cmd, | ||
| "output": "\n".join([sprom_cmd, sprom_output_pos]), | ||
| "exception": None, | ||
| } | ||
| ] | ||
| for switch_ip in switch_ips | ||
| }, | ||
| script.FAIL_UF, | ||
| [ | ||
| ["101", "leaf1", "0x3 Found!"], | ||
| ["103", "leaf3", "0x3 Found!"], | ||
| ], | ||
| ), | ||
| ], | ||
| ) | ||
| def test_logic(run_check, mock_icurl, fabric_nodes, cversion, tversion, mock_conn, expected_result, expected_data): | ||
| result = run_check( | ||
| username="fake_username", | ||
| password="fake_password", | ||
| fabric_nodes=fabric_nodes, | ||
| cversion=script.AciVersion(cversion), | ||
| tversion=script.AciVersion(tversion) if tversion else None, | ||
| ) | ||
| assert result.result == expected_result | ||
| assert result.data == expected_data |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Medium:
Review The Bug RNEis internal terminology and does not give users an actionable, customer-safe remediation. Please point users to the authoritative CSCvv04251 guidance or instruct them to contact Cisco TAC before proceeding, rather than referring to an RNE they may not be able to access.