issue NewValidation: CSCwq28721#358
Conversation
Fixes #316 fixed
monrog2
left a comment
monrog2
left a comment
There was a problem hiding this comment.
Requested changes focus on validation correctness for CSCwp92030 (the canonical defect for duplicate CSCwq28721), Result semantics, and documentation wiring.
| if not tversion: | ||
| return Result(result=MANUAL, msg=TVER_MISSING) | ||
|
|
||
| if cversion.older_than("6.1(1f)") or cversion.newer_than("6.1(5e)"): |
There was a problem hiding this comment.
[Blocking] Vulnerable target upgrades are skipped. Requiring the current version to already be within 6.1(1f)-6.1(5e) makes an upgrade such as 6.0(9f) -> 6.1(1f) return N/A, even though the destination is affected. Gate applicability on the authoritative target-version range (and any actual upgrade-path constraints), and add a crossing-boundary test.
|
|
||
| @check_wrapper(check_title="NTP Server BD SVI Check") | ||
| def ntp_server_bd_svi_check(cversion, tversion, **kargs): | ||
| result = FAIL_UF |
There was a problem hiding this comment.
[Blocking] Use outage severity. CSCwp92030 causes loss of NTP service after the upgrade; it does not prevent the upgrade itself. Please use FAIL_O rather than FAIL_UF so result summaries and customer guidance represent the risk correctly, and update the positive test expectation.
| fp = re.search(fabric_time_pol_regex, fabric_time_pol['fabricRsTimePol']['attributes']['dn']) | ||
| data.append([fp.group("podgroup"), datetime_pol['datetimePol']['attributes']['name']]) | ||
|
|
||
| if not data: |
There was a problem hiding this comment.
[High] Do not turn missing required inventory into PASS. If the datetimePol query unexpectedly returns no objects, data remains empty and this reports success even though APIC should at least have the default policy. Validate the required inventory separately and return ERROR for an incomplete response; retain PASS for a valid inventory with no enabled matching policy. Add an empty-datetimePol test.
| fabric_time_pol_regex = r'uni/fabric/funcprof/podpgrp-(?P<podgroup>[^/]+)/rsTimePol' | ||
| for datetime_pol in datetime_pols: | ||
| for fabric_time_pol in fabric_time_pols: | ||
| if ( |
There was a problem hiding this comment.
[High] Validate the complete defect trigger. The CSCwp92030 conditions require multiple BDs/IPs in the relevant VRF, but this logic flags every enabled leaf NTP-server policy without examining BD/VRF topology. That produces outage failures where the documented trigger is absent. Please detect the complete condition, or reconcile the intended scope and documentation with the canonical defect before failing the check.
| [Stale pconsRA Object][d26] | CSCwp22212 | :warning:{title="Deprecated"} | :no_entry_sign: | ||
| [ISIS DTEPs Byte Size][d27] | CSCwp15375 | :white_check_mark: | :no_entry_sign: | ||
| [Policydist configpushShardCont Crash][d28] | CSCwp95515 | :white_check_mark: | | ||
| [NTP Server BD SVI][d25] | CSCwp92030 | :white_check_mark: | :no_entry_sign: |
There was a problem hiding this comment.
[Medium] This row links to the wrong validation. [d25] resolves to #observer-database-size; the NTP anchor added below is [d29]. Please change this reference to [d29].
2 participants
Fixes #316 fixed
Lab output:
Pytest output: