feat!: ignore .devflow/ wholesale at repo root (clean break, drop nested allowlist)

[dean0x]

Summary

Simplifies how Devflow's .devflow/ runtime folder is git-tracked. Replaces the complex nested .devflow/.gitignore ("ignore everything, then re-include decisions + feature knowledge") with a single .devflow/ entry in the project's root .gitignore. The whole runtime folder is ignored by default; sharing its contents is now opt-in.

Motivated by recurring friction — the selective re-include policy created conflicts and got in the way during normal work. Clean break for v2: no migration sweep.

What changed

New model — the ensure-devflow-init hook is the live, every-project mechanism:

• Appends .devflow/ to the root .gitignore (creates the file if absent; idempotent grep guard)
• Writes a new .root-gitignore-configured marker (renamed from .gitignore-configured) so projects set up under the old model are retrofitted lazily on the next session — no migration needed

Removed the old nested-gitignore machinery:

• getDevflowGitignoreContent() deleted (TS + CJS mirror)
• getGitignoreEntries() now returns ['.claude/', '.devflow/']
• Deleted the sync-devflow-gitignore v1/v2/v3 migrations and the consolidate migration's Step‑5 nested-gitignore creator
• Consolidate migration no longer strips .devflow/ from the root .gitignore

This repo: untracked .devflow/ (git rm --cached, 9 files) and added .devflow/ to the root .gitignore. Working copies remain on disk (now ignored).

Docs: CLAUDE.md updated — the "(committed to git)" annotations for .devflow/features/ and decisions-ledger.jsonl now read "gitignored by default".

Behavioral note (breaking)

Because the hook fires every session, a project that was intentionally committing .devflow/ content (e.g. shared decisions/knowledge) will get .devflow/ auto-added to its root .gitignore. Already-tracked files stay tracked (git honors existing tracking); only new .devflow/ files become ignored. The appended line documents how to opt back in.

Testing

• Full default test suite green: 65 files, 1904 tests, exit 0
• tsc clean; full npm run build clean
• Updated 5 affected test suites to the wholesale-ignore model (project-paths, migrations, shell-hooks, eager-memory-refresh S9, decisions-ledger)

Follow-up — gap fixes (commit c8d41e5)

Self-review of the change above surfaced gaps that this commit closes:

1. Memory-coupling bug (correctness). The only runtime writer of the root .gitignore entry — ensure-devflow-init — was reached only behind the memory-enabled gate in all three memory hooks. A project with memory OFF but decisions/knowledge ON never got .devflow/ ignored (the deleted sync-devflow-gitignore migrations used to cover this). Fixed by decoupling the write from any feature toggle:

• Extracted a single-source scripts/hooks/ensure-root-gitignore helper (the marker fast-path + grep idempotency guard + create/append + comment line).
• ensure-devflow-init now sources it (one implementation of the write).
• The always-on, memory-independent session-start-context sources it too — this is the path that covers memory-off projects.
• Added deterministic init-time ensureDevflowGitignore (appends only .devflow/, never .claude/), called unconditionally when a git root exists.

2. Removed the dead dream-commit machinery. It auto-committed .devflow/ artifacts via git add (no -f) — a permanent no-op now that .devflow/ is ignored wholesale. Deleted the 223-line script + its three skill Auto-commit sections, and dropped the now-orphaned autoCommit dream-config field plus its misleading devflow decisions --status line. Added a purge-orphaned-dream-commit-hook-v1 global migration — the installer copies scripts/ additively (copyDirectory never deletes), so the orphaned hook would otherwise linger in every existing ~/.devflow/scripts/hooks/.

3. Stale "committed to git" comments fixed (migrations.ts ADR-012 → ADR-021 supersession; init.ts features/).

5. Opt-in guidance — a Privacy & Sharing section added to README.md (gitignored by default; how to share everything or selectively re-include decisions.md / pitfalls.md / KNOWLEDGE.md).

Decisions captured this session: ADR-021 (reverse the sharing policy) and PF-014 (the gitignore/memory coupling).

Testing (follow-up): full suite green — 64 files, 1870 tests, exit 0 (deleted dream-commit.test.ts; added ensure-root-gitignore, memory-independent session-start-context, ensureDevflowGitignore, and the new migration). tsc + full npm run build clean.

🤖 Generated with Claude Code