Skip to content

feat(domain-architecture): add code style guides and Galaxy structure for image_build_manager - #4902

Merged
abhishek-sa1 merged 5 commits into
dell:issue-4849-omnia-modernizationfrom
abhishek-sa1:issue-4849-omnia-modernization
Jul 29, 2026
Merged

feat(domain-architecture): add code style guides and Galaxy structure for image_build_manager#4902
abhishek-sa1 merged 5 commits into
dell:issue-4849-omnia-modernizationfrom
abhishek-sa1:issue-4849-omnia-modernization

Conversation

@abhishek-sa1

@abhishek-sa1 abhishek-sa1 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

PR #4902 — Overall File Changes Summary

Fixes #4849

Total Files: 122 (response truncated — showing first 18 visible files)

Documentation Files (docs/)

File Status Changes
docs/README.rst Modified Updated to reflect domain-based docs structure
docs/code-style/README.md Added Code style guide index
docs/code-style/ansible.md Added Ansible/YAML style rules (166 lines)
docs/code-style/general.md Added General code style (copyright headers, file org)
docs/code-style/jinja2.md Added Jinja2 template style guide
docs/code-style/python.md Added Python style guide (pylint, docstrings)
docs/code-style/test_automation.md Added Test automation coding rules (419 lines)
docs/design/ansible-collections-migration.md Added Collection migration design (1,295 lines)

Image Build Manager Domain Files (src/image_build_manager/)

File Status Changes
docs/package-mapping-guide.md Added Functional group package mapping guide
docs/troubleshooting.md Added Common issues and debug tips
galaxy.yml Added Ansible Galaxy metadata (namespace: omnia, name: image_build, v2.3.0)
image_build_manager.yml Removed Top-level playbook removed (moved to playbooks/)
input/project_default/image_build_config.yml Renamed Moved from input/ to input/project_default/, added functional_groups section
library/MIGRATED_FROM_COMMON.md Removed Migration tracking file removed
meta/runtime.yml Added Ansible version compatibility (requires_ansible: >=2.14.0)
output/.gitkeep Removed Empty placeholder removed
playbooks/ansible.cfg Modified Updated paths to plugins/, added collections_paths
playbooks/build/ansible.cfg Added Sub-directory ansible.cfg for build playbooks

Summary of Changes

  1. Code Style Guides Added — 6 new files in docs/code-style/ covering Ansible, Python, Jinja2, General, and Test Automation standards
  2. Design Documentation — Ansible Collections migration design document added
  3. Domain Documentation — Image Build Manager docs added (package mapping, troubleshooting)
  4. Ansible Collection Structuregalaxy.yml and meta/runtime.yml added for Ansible Galaxy compliance
  5. Playbook Reorganization — Top-level image_build_manager.yml removed, restructured into playbooks/ with sub-directory configs
  6. Input File Restructuringimage_build_config.yml moved to input/project_default/ with functional_groups section
  7. Path Updatesansible.cfg updated to use plugins/ instead of library/, added collections_paths
  8. Cleanup — Removed migration tracking file, .gitkeep placeholder

Signed-off-by: Abhishek S A <abhishek.sa3@dell.com>
@abhishek-sa1
abhishek-sa1 marked this pull request as ready for review July 28, 2026 17:38
@abhishek-sa1 abhishek-sa1 changed the title Issue 4849 omnia modernization feat(domain-architecture): add code style guides and Galaxy structure for image_build_manager Jul 28, 2026
Signed-off-by: Abhishek S A <abhishek.sa3@dell.com>
@abhishek-sa1
abhishek-sa1 force-pushed the issue-4849-omnia-modernization branch from 37bca5a to cabfb62 Compare July 28, 2026 17:52
Signed-off-by: Abhishek S A <abhishek.sa3@dell.com>
@abhishek-sa1
abhishek-sa1 merged commit 6789540 into dell:issue-4849-omnia-modernization Jul 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants