Preflight every bulk mutation target before writing#147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144
Acceptance journey
A mixed batch containing one valid task ID and one unknown ID fails the entire request before any apply or save, leaving the valid task unchanged.
Validation impact
mutationChanges
Validation
swift test— 161 tests passedswift run focusrelay-dev validate --impact mutation— 161 tests and release build passededit-tasks j6U8yT2FZht lbJReNIcjBB --operation set_completion --state completed --verifycompleted: falseNote: the AGENTS example includes
--base origin/master, but the currentfocusrelay-dev validatecommand rejects--base; validation used the supported syntax above.