fix(backup): apply configured podSecurityContext to backup CronJob#1655
fix(backup): apply configured podSecurityContext to backup CronJob#1655snecklifter wants to merge 1 commit into
Conversation
The backup CronJob controller does not set podSecurityContext on the backup Job pod spec, even though DevWorkspaceOperatorConfig documents that podSecurityContext applies to all workspace-related pods. This can cause permission or SELinux failures when the backup container reads workspace PVC data on clusters with a custom podSecurityContext. Apply the configured podSecurityContext from DevWorkspaceOperatorConfig to the backup Job pod template, consistent with workspace deployments and PVC cleanup jobs. Fixes: devfile#1636 Assisted-by: Claude Code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Chris Brown <chribrow@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: snecklifter The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reached
More reviews will be available in 58 minutes and 34 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @snecklifter. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
podSecurityContextfromDevWorkspaceOperatorConfigto backup Job pod templatepodSecurityContextis not configured (nil), behavior is unchanged from currentFixes #1636
Test plan
podSecurityContext(customFSGroupChangePolicyandSELinuxOptions)podSecurityContextis nil when not configuredgo test ./controllers/backupcronjob/...)go vetcleanAssisted-by: Claude Code