fix: Postel-tolerant *DisplayConfig in zodgen - #62
Merged
Conversation
Nested AlertChannelDisplayConfig stayed .strict() after response DTOs were relaxed, so additive SMS/phone keys from the API broke list/create. Classify *DisplayConfig as a response shape in the codegen relaxer and regenerate — no hand-authored field lists. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*DisplayConfigis.passthrough()like*Dto/*Responseapi-zod.generated.ts(no hand-authored phone field lists)Why
Pinned CLI 1.5.0 rejects
GET /api/v1/alert-channelswhen the API emits additivedisplayConfigkeys (phoneNumber, …), breaking Docs Exec Validation. Parent DTOs were already Postel-tolerant; nestedAlertChannelDisplayConfigwas not.Test plan
npm test -- --run test/lib/display-config-passthrough.test.tsnpm test/npm run typecheck/npm run lint(run locally before push)make docs-refresh-pins(API@JsonInclude(NON_NULL)unblocks docs against 1.5.0 without this pin)Made with Cursor