lopper: assists: gen_domain_dts: Retain xlnx,fclk node in Linux DT#787
Merged
Conversation
In the static PL flow the PL description (amba_pl) is merged directly into the Linux device tree. There the fabric-clock node (compatible "xlnx,fclk", e.g. clocking0) is the only node that assigns and enables the PL reference clock. PL peripherals such as axi_gpio reference that clock via phandle but do not enable it themselves, so once "xlnx,fclk" is deleted nothing keeps the fabric clock running and Linux turns it off, causing AXI access to the PL peripheral to hang. Drop "xlnx,fclk" from delete_pl_node_in_linux_dt so the fabric-clock node is preserved. Signed-off-by: Aravind Thokala <aravind.thokala@amd.com>
Contributor
Author
|
@onkarharsh , |
Contributor
|
Looks good to me. |
onkarharsh
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the static PL flow the PL description (amba_pl) is merged directly into the Linux device tree. There the fabric-clock node (compatible "xlnx,fclk", e.g. clocking0) is the only node that assigns and enables the PL reference clock. PL peripherals such as axi_gpio reference that clock via phandle but do not enable it themselves, so once "xlnx,fclk" is deleted nothing keeps the fabric clock running and Linux turns it off, causing AXI access to the PL peripheral to hang.
Drop "xlnx,fclk" from delete_pl_node_in_linux_dt so the fabric-clock node is preserved.
Example Lopper command:
LOPPER_DTC_FLAGS="-b 0 -@" ./lopper.py -O outdir -f --enhanced -i lop-a53-imux.dts system-top.dts cortexa53-linux.dts -- gen_domain_dts psu_cortexa53_0 linux_dt