Add project query param to build APIs#503
Open
allburov wants to merge 1 commit into
Open
Conversation
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #452. Combines #493 and #486, co-authored by @gjed and @donhui.
On top of what those PRs did:
get_build_diff()had the same bug, andpromote_build()sends the project as a query parameter, not a JSON body field — that's how JFrog's own client does it (jfrog-client-go promote.go#L39-L41), andrest_post()would percent-encode a hand-appended?anyway.@beliaev-maksim re: dropping the quotes — they were a bug, Artifactory expects a bare key, and spaces in project names can't happen: a Project Key "supports 2 to 32 lowercase alphanumeric characters and hyphens, and must start with a letter" (docs).