Use the session's verify when it is not passed explicitly#505
Open
allburov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #500.
Passing a session with TLS verification disabled had no effect:
ArtifactoryPathdefaultedverifytoTrueand passed it to every request explicitly. Requests gives a request-level argument precedence over the session's own setting, sosession.verifywas always discarded.Now
verifyfalls back to the session when it is not given, in both constructors. The precedence becomes: explicitverify=→ config file entry →session.verify→True. Callers who pass no session are unaffected, and a session that never setverifystill yieldsTrue, since that is the default in requests.