Conversation
… rules is_string() was checked before is_numeric() in validateMin() and validateMax(), causing numeric strings like '25' to be compared by mb_strlen() instead of (float). Changed to is_string() && !is_numeric() so numeric strings use numeric comparison while non-numeric strings still use mb_strlen. Fixes SDF-33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SDF-33:
validateMin()andvalidateMax()insdf/core/Validation/Validator.phpcheckedis_string()beforeis_numeric(), causing numeric strings like"25"to be compared bymb_strlen()instead of(float).Fix
Changed
is_string()→is_string() && !is_numeric()in both methods. This ensures:"Hello") →mb_strlen(length comparison)25,"25") →(float)comparisoncount(unchanged)Tests
Added 9 test cases covering numeric string
min/max/between, pure string fallback, and the intersection (string|minwith numeric value).Full suite: 441 tests, 780 assertions. All passing.