Conversation
Rewrite resolve() with lexical normalization - resolves . and .. segments without realpath() so it works for non-existent paths (put, stream, makeDirectory). Rejects null bytes and throws InvalidArgumentException when a path would escape the storage root. 5 new tests covering traversal in get/put/delete, null bytes, and legitimate .. normalization. Bump 2.3.1 -> 2.3.2.
Switch unserialize from allowed_classes=true to false, blocking object-injection RCE gadget chains. Brings FileDriver in line with RedisDriver and MemcachedDriver. Breaking for users caching objects - documented migration path in wiki. Bump 2.3.2 -> 2.3.3.
Owner
Author
|
ready for code review - (experimental, used saddle) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the final critical security finding (SDF-59) from the deep security audit. Bumps 2.3.2 → 2.3.3.
Fix
sdf/core/Cache/FileDriver.php:265unserialize(..., ['allowed_classes' => true])→false. Blocks object-injection RCE gadget chains (Monolog, Guzzle, etc.) - cached objects now become__PHP_Incomplete_Class(no__wakeup/__destructfires). BringsFileDriverin line withRedisDriverandMemcachedDriverwhich already usedfalse.Breaking change
Users who cached PHP objects via
FileDriverwill now getnullfromCache::get()instead of an object instance. Migration:Documented in wiki/libraries/caching.md - new "Object unserialization safety (v2.3.3+)" section.
Tests
1 new test: test_file_driver_refuses_object_unserialization - writes serialized stdClass directly to cache file, asserts get() returns null.
Verification
Audit progress - all 6 critical issues resolved