fix: resolve eslint warnings, add saved properties page, and e2e test

CONTRIBUTING.md

@@ -28,33 +28,111 @@ If you're looking for tasks to pick up, start with `docs/ISSUES_CATALOG.md`.
 
 ## Development setup
 
-### Frontend
+This repository has three independently tool-chained projects. Use the package manager and version below that matches CI.
+
+### Prerequisites
+
+- Node.js 22.x (CI uses Node 22)
+- pnpm 9.15.5 for the frontend
+- npm for the backend (CI uses `npm ci`)
+- Rust stable with `rustfmt` and `clippy` for the contracts workspace
+- Docker Desktop (optional, but useful for PostgreSQL and the full-stack compose setup)
+
+### Frontend setup (pnpm, Node 22)
 
 ```bash
 cd frontend
-npm install
-npm run dev
+corepack enable
+pnpm install --frozen-lockfile
+pnpm run lint
+pnpm run build
 ```
 
-### Backend
+- The frontend uses pnpm, not npm.
+- The authoritative lockfile is `frontend/pnpm-lock.yaml`.
+- `frontend/package-lock.json` is stale and should not be used; do not run `npm install` in this directory.
+
+### Backend setup (npm, Node 22)
 
 ```bash
 cd backend
-npm install
+npm ci
 cp .env.example .env
+# Optional but recommended for local API development:
+docker compose up postgres -d
+npm run lint
+npm run test:ci
+npm run openapi:validate
+```
+
+The backend uses npm, not pnpm. The CI job runs `npm ci` and then the lint/test/OpenAPI checks below.
+
+Required environment variables for local backend work:
+
+- `cp .env.example .env` to create a local environment file.
+- `DATABASE_URL` is required for the API server. The default example points at a local PostgreSQL instance.
+- `ENCRYPTION_KEY` is required for local encryption helpers; the example value is fine for local development.
+- `CUSTODIAL_WALLET_MASTER_KEY_V1` and `CUSTODIAL_WALLET_MASTER_KEY_V2` can be left empty for basic local development, but wallet-related flows will need real values.
+- `RESEND_API_KEY` can stay empty; OTP delivery defaults to the console provider.
+
+For local development, the easiest path is to start PostgreSQL and then run the API:
+
+```bash
+cd backend
+cp .env.example .env
+docker compose up postgres -d
 npm run dev
 ```
 
-### Contracts
+The CI test command (`npm run test:ci`) excludes the network-dependent suites, so it does not require external Soroban or webhook services to pass.
+
+### Contracts setup (Rust stable + fmt/clippy)
 
 ```bash
 cd contracts
-cargo test
-stellar contract build
+rustup toolchain install stable
+rustup component add rustfmt clippy
+cargo fmt --all -- --check
+cargo clippy --workspace --all-targets --all-features
+cargo test --workspace
 ```
 
 For Soroban CLI deployment instructions see `contracts/README.md`.
 
+## Before opening a PR (required checks)
+
+Run the CI-equivalent commands from the matching directory before you push:
+
+### Frontend checks
+
+```bash
+cd frontend
+pnpm install --frozen-lockfile
+pnpm run lint
+pnpm run build
+```
+
+### Backend checks
+
+```bash
+cd backend
+npm ci
+npm run lint
+npm run test:ci
+npm run openapi:validate
+```
+
+### Contracts checks
+
+```bash
+cd contracts
+cargo fmt --all -- --check
+cargo clippy --workspace --all-targets --all-features
+cargo test --workspace
+```
+
+If your PR changes UI, include screenshots or a short screen recording in the PR description.
+
 ## Creating an issue
 
 Before opening a new issue:
@@ -81,47 +159,6 @@ Before opening a new issue:
 - Ask clarifying questions early.
 - If you’re blocked for >24h, leave an update.
 
-## Before opening a PR (required checks)
-
-Run the checks for the area you changed.
-
-### Frontend checks
-
-```bash
-cd frontend
-npm run lint
-npm run build
-```
-
-If your PR changes UI, include **screenshots** (or a short screen recording) in the PR description.
-
-#### UI/Image change verification
-
-For PRs that modify UI components or add/change images:
-
-- Include before/after screenshots showing the changes
-- For new features, provide screenshots of different states (loading, error, success)
-- For responsive changes, include screenshots at different breakpoints (mobile, tablet, desktop)
-- Verify images are optimized and not excessively large (use tools like ImageOptim, TinyPNG, or Next.js Image component)
-- Confirm accessibility: check color contrast, alt text for images, keyboard navigation
-
-### Backend checks
-
-```bash
-cd backend
-npm run lint
-npm run typecheck
-npm run build
-```
-
-### Contracts checks
-
-```bash
-cd contracts
-cargo test
-stellar contract build
-```
-
 ## If the repository is renamed on GitHub
 
 If the organization renames this repository, GitHub will usually redirect the old URL to the new one.

README.md

@@ -1,4 +1,4 @@
-# Shelterflex
+# Shelterflex 
 
 Shelterflex is a **Rent Now, Pay Later (RNPL)** platform that enables tenants to secure rental properties with an initial deposit and pay the remaining balance in monthly installments — while allowing landlords to list properties directly, reducing reliance on traditional agents.
 
@@ -63,12 +63,12 @@ New contributors can run **just one** component without setting up the others.
 
 ## Option A: Frontend Only
 
-**Prerequisites:** Node.js 20+
+**Prerequisites:** Node.js 22, pnpm 9.15.5
 
 ```bash
 cd frontend
-npm install
-npm run dev
+pnpm install --frozen-lockfile
+pnpm run dev
 ```
 
 - Runs on: `http://localhost:3000`
@@ -77,11 +77,11 @@ npm run dev
 
 ### Option B: Backend Only
 
-**Prerequisites:** Node.js 20+
+**Prerequisites:** Node.js 22
 
 ```bash
 cd backend
-npm install
+npm ci
 cp .env.example .env
 npm run dev
 ```
@@ -92,7 +92,7 @@ npm run dev
 
 ### Option C: Contracts Only
 
-**Prerequisites:** Rust (stable), Soroban CLI (`stellar`)
+**Prerequisites:** Rust stable with `rustfmt` and `clippy`, Soroban CLI (`stellar`)
 
 ```bash
 cd contracts

backend/README.md

@@ -4,15 +4,17 @@ Node.js backend for Shelterflex.
 
 ## Setup
 
-> **Package manager:** This project uses **npm**. Use `npm install` (not `pnpm` or `yarn`) to match
-> the `package-lock.json` lockfile that is committed to the repository.
+> **Package manager:** This project uses **npm**. Use `npm ci` (not `pnpm`) to match the lockfile and CI workflow.
 
 ```bash
-npm install
+npm ci
 cp .env.example .env
 npm run dev
 ```
 
+- The backend CI job runs `npm ci` from this directory.
+- For local API development, make sure PostgreSQL is available and that the environment file contains at least `DATABASE_URL` and `ENCRYPTION_KEY`.
+
 ## Testing
 
 Run the integration test suite:
@@ -46,9 +48,23 @@ Tests are located in `src/**/*.test.ts` files and use Vitest + Supertest.
 
 ## Database migrations
 
-SQL migrations live in `migrations/` and are applied in filename order.
+SQL migrations live in `migrations/`.
+
+At runtime (`src/migrations/runMigrations.ts`), migrations are:
+
+- tracked by **exact filename** in `schema_migrations.filename`
+- wrapped in a transaction per file
+- skipped when that exact filename already exists in `schema_migrations`
+
+Because tracking is filename-based, renaming an already-applied migration is unsafe (it can make an applied migration look unapplied and cause re-execution).
 
-The repository includes a migration runner script in `src/repositories/test.ts` that:
+Ordering is resolved by `src/migrations/migrationOrdering.ts`:
+
+- legacy files are pinned in `migrations/migration-order.manifest.json` with unique integer positions
+- new files not listed in the manifest must use `YYYYMMDDHHMMSS_description.sql`
+- timestamp-prefixed files are appended in lexicographic order (chronological) and duplicate timestamps are rejected
+
+The repository includes a database setup script in `src/repositories/test.ts` that:
 
 - creates a `schema_migrations` table if missing
 - applies any `.sql` files not yet recorded
@@ -497,4 +513,3 @@ LOCAL_STORAGE_DIR=/tmp/shelterflex-dev
 ```
 
 This is useful for local development when you don't want to run MinIO.
-

backend/docs/openapi.yml

@@ -179,6 +179,41 @@ paths:
         default:
           $ref: "#/components/responses/Error"
 
+  /api/v1/user/preferences/notifications/messages-email:
+    patch:
+      summary: Update message email preference
+      description: Opt in or out of delayed message email notifications.
+      operationId: updateMessageEmailPreference
+      tags:
+        - User Preferences
+      security:
+        - bearerAuth: []
+      requestBody:
+        required: true
+        content:
+          application/json:
+            schema:
+              type: object
+              required:
+                - enabled
+              properties:
+                enabled:
+                  type: boolean
+      responses:
+        "200":
+          description: Preference updated
+          content:
+            application/json:
+              schema:
+                type: object
+                required:
+                  - messageEmailsEnabled
+                properties:
+                  messageEmailsEnabled:
+                    type: boolean
+        default:
+          $ref: "#/components/responses/Error"
+
   /api/auth/wallet/challenge:
     post:
       summary: Create wallet login challenge
@@ -2131,7 +2166,7 @@ paths:
   /api/webhooks/payments/{rail}:
     post:
       summary: Payments webhook
-      description: Ingest payment provider webhook. Idempotent by (rail, externalRef). Signature validation can be enabled.
+      description: Ingest payment provider webhook. Idempotent by provider event ID plus canonical reference. Signature validation is always enforced in production and can be enabled in non-production with WEBHOOK_SIGNATURE_ENABLED=true.
       operationId: paymentsWebhook
       tags:
         - Webhooks

backend/migrations/040_property_inspections.sql

@@ -0,0 +1,69 @@
+-- Property inspection system for freelance property inspectors
+
+-- Inspector profiles
+CREATE TABLE IF NOT EXISTS inspector_profiles (
+    user_id TEXT PRIMARY KEY,
+    verification_status TEXT NOT NULL DEFAULT 'pending'
+        CHECK (verification_status IN ('pending', 'verified', 'suspended')),
+    bio TEXT,
+    service_areas JSONB NOT NULL DEFAULT '[]'::jsonb,
+    completed_inspections INTEGER NOT NULL DEFAULT 0,
+    created_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    updated_at TIMESTAMPTZ NOT NULL DEFAULT NOW()
+);
+
+CREATE INDEX IF NOT EXISTS inspector_profiles_verification_status_idx ON inspector_profiles (verification_status);
+CREATE INDEX IF NOT EXISTS inspector_profiles_service_areas_idx ON inspector_profiles USING GIN (service_areas);
+
+-- Property inspections
+CREATE TABLE IF NOT EXISTS property_inspections (
+    id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
+    listing_id UUID NOT NULL REFERENCES whistleblower_listings(listing_id) ON DELETE CASCADE,
+    inspector_id TEXT NOT NULL REFERENCES inspector_profiles(user_id) ON DELETE CASCADE,
+    status TEXT NOT NULL DEFAULT 'pending'
+        CHECK (status IN ('pending', 'in_progress', 'submitted', 'approved', 'rejected')),
+    scheduled_at TIMESTAMPTZ,
+    submitted_at TIMESTAMPTZ,
+    approved_at TIMESTAMPTZ,
+    inspector_notes TEXT,
+    created_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    updated_at TIMESTAMPTZ NOT NULL DEFAULT NOW()
+);
+
+CREATE INDEX IF NOT EXISTS property_inspections_listing_id_idx ON property_inspections (listing_id);
+CREATE INDEX IF NOT EXISTS property_inspections_inspector_id_idx ON property_inspections (inspector_id);
+CREATE INDEX IF NOT EXISTS property_inspections_status_idx ON property_inspections (status);
+
+-- Inspection checklist items
+CREATE TABLE IF NOT EXISTS inspection_checklist_items (
+    id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
+    inspection_id UUID NOT NULL REFERENCES property_inspections(id) ON DELETE CASCADE,
+    category TEXT NOT NULL
+        CHECK (category IN ('structural', 'plumbing', 'electrical', 'safety', 'exterior')),
+    item TEXT NOT NULL,
+    result TEXT NOT NULL
+        CHECK (result IN ('pass', 'fail', 'na')),
+    notes TEXT,
+    created_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    updated_at TIMESTAMPTZ NOT NULL DEFAULT NOW()
+);
+
+CREATE INDEX IF NOT EXISTS inspection_checklist_items_inspection_id_idx ON inspection_checklist_items (inspection_id);
+CREATE INDEX IF NOT EXISTS inspection_checklist_items_category_idx ON inspection_checklist_items (category);
+
+-- Inspection photos
+CREATE TABLE IF NOT EXISTS inspection_photos (
+    id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
+    inspection_id UUID NOT NULL REFERENCES property_inspections(id) ON DELETE CASCADE,
+    url TEXT NOT NULL,
+    caption TEXT,
+    taken_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    created_at TIMESTAMPTZ NOT NULL DEFAULT NOW()
+);
+
+CREATE INDEX IF NOT EXISTS inspection_photos_inspection_id_idx ON inspection_photos (inspection_id);
+
+-- Add trust score fields to whistleblower_listings
+ALTER TABLE whistleblower_listings 
+ADD COLUMN IF NOT EXISTS trust_score INTEGER DEFAULT 50 CHECK (trust_score >= 0 AND trust_score <= 100),
+ADD COLUMN IF NOT EXISTS has_verified_inspection BOOLEAN DEFAULT FALSE;