test: replace obsolete model integration suites#47
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8427a62d2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| results | ||
| .results | ||
| .iter() | ||
| .any(|result| result.file_path == created.path) |
There was a problem hiding this comment.
Assert the appended content is indexed
In this test the note at created.path was already indexed by create_note before the append, and the harness has no competing notes; search_internal's semantic lane can return that same file for any query even if append_to_note never re-indexes the appended text. This lets a stale index pass the test; assert that the returned snippet/content contains the appended phrase, or add a competing document and require the updated note to rank first, so the test actually covers the index update.
Useful? React with 👍 / 👎.
Refs #44.
What changed
Embeddermodules.run_index_shared,Store, sqlite-vec, andMockLlm.Why
The existing files were marked ignored, but they no longer compiled under
cargo test --all-targetsbecause their backend APIs were deleted during the sqlite-vec/llama.cpp migrations. Deleting them would hide the coverage loss; this updates the tests to the current architecture instead.Impact
Five integration tests now run locally without network or model dependencies, and all targets compile again.
Validation
cargo fmt --checkcargo clippy -- -D warningscargo test --test integration --test write_pipeline— 5 passedcargo test --all-targets --no-run— passed