Skip to content

test: replace obsolete model integration suites#47

Open
saagpatel wants to merge 1 commit into
devwhodevs:mainfrom
saagpatel:agent/model-free-integration-tests
Open

test: replace obsolete model integration suites#47
saagpatel wants to merge 1 commit into
devwhodevs:mainfrom
saagpatel:agent/model-free-integration-tests

Conversation

@saagpatel

Copy link
Copy Markdown

Refs #44.

What changed

  • Replace the obsolete integration suite that referenced removed HNSW and ONNX Embedder modules.
  • Exercise current indexing/search through run_index_shared, Store, sqlite-vec, and MockLlm.
  • Exercise create, append, immediate searchability, incremental add/change/delete behavior, and mtime-conflict rejection without model downloads.

Why

The existing files were marked ignored, but they no longer compiled under cargo test --all-targets because their backend APIs were deleted during the sqlite-vec/llama.cpp migrations. Deleting them would hide the coverage loss; this updates the tests to the current architecture instead.

Impact

Five integration tests now run locally without network or model dependencies, and all targets compile again.

Validation

  • cargo fmt --check
  • cargo clippy -- -D warnings
  • cargo test --test integration --test write_pipeline — 5 passed
  • cargo test --all-targets --no-run — passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8427a62d2b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/write_pipeline.rs
results
.results
.iter()
.any(|result| result.file_path == created.path)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Assert the appended content is indexed

In this test the note at created.path was already indexed by create_note before the append, and the harness has no competing notes; search_internal's semantic lane can return that same file for any query even if append_to_note never re-indexes the appended text. This lets a stale index pass the test; assert that the returned snippet/content contains the appended phrase, or add a competing document and require the updated note to rank first, so the test actually covers the index update.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant