Drop the blue circle behind element icons - #63
Merged
Conversation
The last commit gave the map pins red teardrops, but the tooltip and the detail screen still framed the same element's emoji in a solid blue `accent` disc, so one place said red and the other said blue. The disc also rendered unconditionally: an element with `icon: ""` showed an empty blue circle holding nothing. Remove the badge instead of recoloring it — the emoji already carries its own color, and a filled shape behind it only competes. Rendering the glyph as a direct flex child means no icon renders no element at all, so the title and address start at the card edge rather than indenting past a placeholder. Bump the glyph a size to keep the visual weight the disc used to carry. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous PR (#62) gave the map pins red teardrops, but the map tooltip and the element detail screen still framed the same element's emoji in a solid blue
accentdisc — so one place said red and the other said blue for the same saved place. The disc also rendered unconditionally, meaning an element withicon: ""showed an empty blue circle holding nothing.iconWrapbadge fromElementPreviewCardandElementDetailScreenrather than recoloring it: the emoji already carries its own color, and a filled shape behind it only competes with it.element.icon, so no icon renders nothing at all and the title/address fill the space instead of indenting past an empty placeholder.theme.accentis still used for links and label chips, so no theme token became dead here.Test plan
bunx tsc --noEmit— cleanbun run lint— cleanbun run test -- --ci— 7 passed🤖 Generated with Claude Code