Skip to content

feat: Update to v14, support disableIngressValidation and senderInfo#271

Merged
adamspofford-dfinity merged 3 commits into
mainfrom
spofford/v14
Jun 9, 2026
Merged

feat: Update to v14, support disableIngressValidation and senderInfo#271
adamspofford-dfinity merged 3 commits into
mainfrom
spofford/v14

Conversation

@adamspofford-dfinity

Copy link
Copy Markdown
Contributor

No description provided.

@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner June 8, 2026 20:16
Copilot AI review requested due to automatic review settings June 8, 2026 20:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the @dfinity/pic package to PocketIC v14 and extends the PocketIc API surface to support (1) disabling ingress validation on instance creation and (2) attaching signed senderInfo to query/update canister calls.

Changes:

  • Bump bundled PocketIC binary default version to package:14.0.0.
  • Add disableIngressValidation to instance creation options (request encoding included).
  • Add senderInfo to queryCall / updateCall options (request encoding included) and add tests for both features.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/pic/tests/src/sender-info.spec.ts Adds an integration test asserting senderInfo is accepted on query/update calls.
packages/pic/tests/src/disable-ingress-validation.spec.ts Adds an integration test asserting unsigned non-anonymous ingress is rejected/accepted depending on disableIngressValidation.
packages/pic/src/pocket-ic.ts Passes through senderInfo from public call options to the client request.
packages/pic/src/pocket-ic-types.ts Introduces the SenderInfo type and exposes senderInfo + disableIngressValidation in public option interfaces.
packages/pic/src/pocket-ic-client-types.ts Encodes disable_ingress_validation and sender_info into the server request payloads.
packages/pic/postinstall.mjs Updates the default PocketIC artifact version to v14.
CHANGELOG.md Documents the v14 bump and the two new options.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/pic/tests/src/sender-info.spec.ts Outdated
Comment thread packages/pic/tests/src/disable-ingress-validation.spec.ts Outdated
lwshang
lwshang previously approved these changes Jun 9, 2026
@adamspofford-dfinity adamspofford-dfinity added this pull request to the merge queue Jun 9, 2026
Merged via the queue into main with commit 9e71100 Jun 9, 2026
15 checks passed
@adamspofford-dfinity adamspofford-dfinity deleted the spofford/v14 branch June 9, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants