feat: Update to v14, support disableIngressValidation and senderInfo#271
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the @dfinity/pic package to PocketIC v14 and extends the PocketIc API surface to support (1) disabling ingress validation on instance creation and (2) attaching signed senderInfo to query/update canister calls.
Changes:
- Bump bundled PocketIC binary default version to
package:14.0.0. - Add
disableIngressValidationto instance creation options (request encoding included). - Add
senderInfotoqueryCall/updateCalloptions (request encoding included) and add tests for both features.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/pic/tests/src/sender-info.spec.ts | Adds an integration test asserting senderInfo is accepted on query/update calls. |
| packages/pic/tests/src/disable-ingress-validation.spec.ts | Adds an integration test asserting unsigned non-anonymous ingress is rejected/accepted depending on disableIngressValidation. |
| packages/pic/src/pocket-ic.ts | Passes through senderInfo from public call options to the client request. |
| packages/pic/src/pocket-ic-types.ts | Introduces the SenderInfo type and exposes senderInfo + disableIngressValidation in public option interfaces. |
| packages/pic/src/pocket-ic-client-types.ts | Encodes disable_ingress_validation and sender_info into the server request payloads. |
| packages/pic/postinstall.mjs | Updates the default PocketIC artifact version to v14. |
| CHANGELOG.md | Documents the v14 bump and the two new options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lwshang
previously approved these changes
Jun 9, 2026
lwshang
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.