Fix RadioFrequency string formatting#714
Merged
Merged
Conversation
The verb was transposed ("%f.3%s") and printed hertz rather than
megahertz, so 251MHz AM rendered as "251000000.000000.3AM" instead of
"251.000AM". Nothing calls this today, so the bug was latent; go vet
doesn't catch it because %f is a valid verb for a float64 and ".3"
reads as literal text.
Co-Authored-By: Claude <noreply@anthropic.com>
dharmab
force-pushed
the
fix/radio-frequency-string
branch
from
July 26, 2026 14:25
de48678 to
edc71fb
Compare
dharmab
changed the title
dharmab
enabled auto-merge (rebase)
July 26, 2026 14:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Split off from #712, which found this while working in the same area.
RadioFrequency.String()had a transposed format verb ("%f.3%s") and formatted the frequency in hertz rather than megahertz, so 251MHz AM rendered as"251000000.000000.3AM"instead of"251.000AM".go vetdoesn't catch it because%fis a valid verb for afloat64and.3reads as literal text.Nothing calls
String()today, so this is latent rather than user-visible.Fix
fmt.Sprintf("%.3f%s", f.Frequency.Megahertz(), suffix), plus a regression test.Testing
🤖 Generated with Claude Code