Simplify WaitGroup usage in SRS client with wg.Go() - #717
Merged
Conversation
dharmab
enabled auto-merge (squash)
July 26, 2026 15:06
Replaces the last remaining wg.Add()/go func()/defer wg.Done() blocks in Client.Run with wg.Go(), matching the style already used elsewhere in the same method and across the rest of the codebase. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dharmab
force-pushed
the
simplify-waitgroup-go
branch
from
July 26, 2026 16:33
a3aed0d to
23ed15b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wg.Add()+go func() { defer wg.Done(); ... }()blocks inClient.Run(pkg/simpleradio/client.go) withwg.Go(func() { ... })WaitGroup.GoTest plan
make lint && make vet && make fix && make format && go mod tidy— clean, no diffmake test— 1143 tests pass🤖 Generated with Claude Code