Add baseline test coverage for pkg/simpleradio - #720
Merged
Conversation
Split off from the SRS transmission-splitting fix: these tests cover pre-existing, unrelated behavior (frame encode/decode round trips, frequency/radio matching, client sync filtering, server settings, and message JSON) rather than anything changed by that fix, so they can be reviewed independently. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dharmab
enabled auto-merge (rebase)
July 26, 2026 20:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Split off from #712 (fixing SRS transmissions being split into fragments). That PR added a large test suite to
pkg/simpleradio, but most of it exercises pre-existing behavior unrelated to the fix. Splitting it out here lets it be reviewed independently of the fix's regression tests.What's covered
frame_test.go)frequency_test.go)sync_test.go)message_test.go)types/message_test.go)typespackage (types/radio_test.go,types/info_test.go)None of this touches
receive.go's transmission-window logic, which is what #712 changes and tests separately.🤖 Generated with Claude Code