Fix stale color profile subtitle after switching profiles - #11
Merged
didriksg merged 1 commit intoJul 30, 2026
Merged
Conversation
Owner
|
Thanks so much for this, @shaw-baobao! 🙏 I tested it locally and the color-profile subtitle now updates correctly right after switching profiles. Clean, well-scoped fix, and much appreciated. Merging it in now, thanks for contributing to Crisp! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
DisplayDetailView loaded the subtitle when its display ID task ran, while ColorProfileView managed the picker selection locally. A successful profile change therefore updated the picker state without refreshing the parent subtitle.
Testing