Skip to content

Fix stale color profile subtitle after switching profiles - #11

Merged
didriksg merged 1 commit into
didriksg:mainfrom
shaw-baobao:fix/color-profile-subtitle-sync
Jul 30, 2026
Merged

Fix stale color profile subtitle after switching profiles#11
didriksg merged 1 commit into
didriksg:mainfrom
shaw-baobao:fix/color-profile-subtitle-sync

Conversation

@shaw-baobao

Copy link
Copy Markdown

Summary

  • Share the active color profile name between the display detail row and the profile picker through a binding.
  • Update the row subtitle immediately after ColorSync applies a new profile successfully.
  • Preserve the existing subtitle and selection when profile application fails.

Root cause

DisplayDetailView loaded the subtitle when its display ID task ran, while ColorProfileView managed the picker selection locally. A successful profile change therefore updated the picker state without refreshing the parent subtitle.

Testing

  • Ran a full-project Swift type check.
  • Built and launched Crisp 1.2.0 locally on macOS 27.
  • Switched an external display to the Mi Monitor profile and confirmed that the row subtitle updates immediately.

@didriksg

Copy link
Copy Markdown
Owner

Thanks so much for this, @shaw-baobao! 🙏 I tested it locally and the color-profile subtitle now updates correctly right after switching profiles. Clean, well-scoped fix, and much appreciated. Merging it in now, thanks for contributing to Crisp!

@didriksg
didriksg merged commit 01fd05d into didriksg:main Jul 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants