You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@sbillinge ready for review. This should be the end of the migration process, and migration is ready to be merged into main! I've checked over all the files and made sure they're up to standards.
Here are the results of running precommit:
check yaml...............................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check for case conflicts.................................................Passed
check for merge conflicts................................................Passed
check toml...............................................................Passed
check for added large files..............................................Passed
black....................................................................Passed
flake8...................................................................Passed
isort....................................................................Passed
nbstripout...........................................(no files to check)Skipped
Prevent Commit to Main Branch............................................Passed
codespell................................................................Passed
prettier.................................................................Passed
docformatter.............................................................Passed
And here are the results of running pytest on the minimal tests that I wrote:
nice! Thanks. One last thing. Please can you check that all the github workflows are consistent with those in the diffpy.pdfgetx project rather than scikit package. I checked on the tests-on-pr and it is, but please double check all the other workflows.
I will merge this. I will merge migration into main when you confirm the workflows are all ok.
Please then make an issue to update the build script in the main xpdfsuite repo to remove the migration branch from this project, and make that PR if possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.