Use raw path when building request signature#229
Merged
Conversation
The signature is computed over the URL path, but getPath() read the decoded path from URI#getPath() rather than the encoded form actually transmitted. Any path with percent-encoded characters therefore produced a signature the server could not reproduce, and the request was refused. Read the path via URI#getRawPath() so client and server canonicalize the same bytes. Tests cover an encoded path and a plain-ASCII path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referencing issue #220
The signature is computed over the URL path, but getPath() read the decoded path from URI#getPath() rather than the encoded form actually transmitted. Any path with percent-encoded characters therefore produced a signature the server could not reproduce, and the request was refused.
Read the path via URI#getRawPath() so client and server canonicalize the same bytes. Tests cover an encoded path and a plain-ASCII path.