DBAAS-8142: Add GET/PUT /v2/databases/{uuid}/do_settings#1195
Open
lprasanth-nadiminti wants to merge 1 commit into
Open
DBAAS-8142: Add GET/PUT /v2/databases/{uuid}/do_settings#1195lprasanth-nadiminti wants to merge 1 commit into
lprasanth-nadiminti wants to merge 1 commit into
Conversation
Adds dedicated DO settings endpoint to the public API spec: - GET databases_get_do_settings (database:read) - PUT databases_update_do_settings (database:update, 204/400/422) Backend: cthulhu PR 154593. Model from digitalocean#1137.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the dedicated DO settings endpoint to the public API spec:
/v2/databases/{database_cluster_uuid}/do_settings— retrieve current service CNAMEs/v2/databases/{database_cluster_uuid}/do_settings— update service CNAMEs (204 on success)Backend shipped in cthulhu #154593. Model (
do_settings.yml) and create/replica fields already merged in #1137.Test plan
make bundlepasses (zero Spectral errors)/do_settings8142845, clusterbkp-st2-doset-mysql-0619/ccadf744-1481-43ab-b25f-128a79f2c3bd):service_cnames: []api.myapp.io,a1.x.com)service_cnames: [])service_cnames: []per_table_metrics)do_settings({})