fix(theme): eliminate dark-mode first-paint flash#10
Open
yyyr-p wants to merge 1 commit into
Open
Conversation
Move the theme-init IIFE from next/script beforeInteractive (which defers execution to the client bootstrap) into a native synchronous <head><script> that runs at HTML parse time — before the browser reaches <body> and its first style calculation. Extract the shared localStorage key into a single THEME_STORAGE_KEY constant so the reader (init script) and writer (ThemeToggle) cannot drift silently. Add a node:vm decision-matrix test covering 11 scenarios (stored preference priority, system preference fallback, /admin forced light, localStorage/matchMedia errors, inline-script safety).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
next/scriptbeforeInteractiveinto a native synchronous<head><script>that executes at HTML parse time — before the browser reaches<body>and its first style calculationpriceai-themelocalStorage key into a singleTHEME_STORAGE_KEYconstant so the reader (init script) and writer (ThemeToggle) cannot drift silentlynode:vmdecision-matrix test covering 11 scenarios (stored preference priority, system preference fallback,/adminforced light, localStorage/matchMedia errors, inline-script safety)Verification
npm run test:theme-init— 11 cases passnpm test— full suite passesnpm run typecheck— cleannpm run lint— clean (1 pre-existing unrelated warning)npm run build— production build succeeds/adminremains light; ThemeToggle preserves its existing color transition animation