fix(theme-toggle): sync theme across tabs on storage event#11
Open
yyyr-p wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThemeToggle'sstorageevent handler previously just calledonStoreChange, which madeuseSyncExternalStorere-read the DOM. But the DOM was never modified by another tab — astorageevent means a peer tab wrote tolocalStorage, while this tab's DOM state was unchanged, so cross-tab theme switches were silently dropped.Fix: filter
storageevents byTHEME_STORAGE_KEY, parse the target theme fromevent.newValue, callapplyThemeto sync this tab'sdataset.theme/style.colorSchemeto that value, then triggeronStoreChangesouseSyncExternalStorere-renders. Unknown or missingnewValueis ignored; events for other storage keys are untouched;removeEventListeneruses the same stable handler reference so no listener leaks.Admin pages do not render
ThemeToggle(SiteHeaderis not mounted undersrc/app/admin/), so this handler never fires in an admin tab and does not conflict with the initial-paint script's forced-light policy on `/admin`.Test plan