docs(plan): make API key limit atomic#107
Open
dirtybits wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/keys' five-active-key limitVerification
git diff --check main...HEADDeferred implementation
The plan intentionally defers the code change because it requires a serverless/Neon transaction-semantics validation before altering the API-key database path. No database operation, dependency change, authentication-flow change, or chain action was made.
Plan:
.agents/plans/api-key-active-limit-atomicity.plan.mdNote
Low Risk
Documentation-only; no production code, schema, or auth behavior changes.
Overview
Adds an execution plan (
.agents/plans/api-key-active-limit-atomicity.plan.md) for a future fix; no runtime or database changes in this PR.The plan records that
POST /api/keystoday enforces the five-active-key cap with a separateSELECTof non-revoked keys and a laterINSERT, which concurrent valid create requests can race past. It specifies an additivecreate_api_key_with_active_limitPL/pgSQL helper inweb/lib/db.ts(per-ownerpg_advisory_xact_lock, count, then insert in one transaction), a single helper call fromweb/app/api/keys/route.tsafter nonce consumption with the same 400 quota message, and focused route/schema tests. Rollout, rollback, blockers (Neon/serverless lock semantics), and explicit out-of-scope items are included; implementation stays deferred until those are validated.Reviewed by Cursor Bugbot for commit 76ccb16. Bugbot is set up for automated code reviews on this repo. Configure here.