fix(base): centralize legacy contract detection#108
Open
dirtybits wants to merge 1 commit into
Open
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_8c29411a-a6b6-4878-820a-ff20a4174a5c) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_chain_program_idEVM check through the sharedisEvmShapedAddresshelperTest Plan
npm test --workspace @agentvouch/web -- --maxWorkers=1 --no-fileParallelism __tests__/lib/baseListing-currency.test.tsnpm run typechecknpm run lint:webnpm exec -- prettier --check web/lib/adapters/baseListing.ts web/__tests__/lib/baseListing-currency.test.tsgit diff --checkNot run
Note
Low Risk
Small helper refactor in Base listing adapter with targeted unit tests; behavior for non-EVM legacy IDs is explicitly preserved.
Overview
getExpectedBaseContractnow decides whether legacyon_chain_program_idcan stand in forevm_contract_addressvia sharedisEvmShapedAddressfromchainAddress, replacing an inlinestartsWith("0x")check.When
evm_contract_addressis missing, EVM-shaped legacy IDs still go throughrequireBaseEvmAddress; Solana-style (non-0x) legacy IDs are skipped and the configured Base contract is used instead of treating the program id as a contract.Regression tests cover both the EVM legacy fallback and the non-EVM ignore path in
baseListing-currency.test.ts.Reviewed by Cursor Bugbot for commit 702d40a. Bugbot is set up for automated code reviews on this repo. Configure here.