Enable CARGO_BUILD_WARNINGS=deny in CI#2385
Merged
Merged
Conversation
Collaborator
Author
|
Build failed successfully: https://github.com/divviup/divviup-api/actions/runs/29946843836/job/89014274389?pr=2385#step:10:941 I'm going to rebase this after having merged #2384 to fix it. |
divergentdave
force-pushed
the
david/ci-deny-warnings
branch
from
July 22, 2026 18:34
1091bd3 to
cf588ac
Compare
tgeoghegan
approved these changes
Jul 22, 2026
Contributor
|
Thanks for the follow through here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the new CARGO_BUILD_WARNINGS to fail CI if there are any warnings. (This is a bit nicer than using
RUSTFLAGS="-D warnings"because it doesn't affect Cargo's key for cached build output reuse, and it doesn't fight withRUSTFLAGSset in.cargo/config.toml)