more rigorous rustfmt linting#111
Merged
Merged
Conversation
tgeoghegan
force-pushed
the
timg/normalize-comments
branch
from
July 13, 2026 17:53
6b77a19 to
0492a53
Compare
tgeoghegan
marked this pull request as ready for review
July 13, 2026 17:53
divergentdave
approved these changes
Jul 13, 2026
| */ | ||
| /// Encapsulated key and ciphertext. | ||
| /// | ||
| /// Obtained from [`crate::base_mode_open::base_mode_open`]. |
Collaborator
There was a problem hiding this comment.
This is returned by seal, not open.
Suggested change
| /// Obtained from [`crate::base_mode_open::base_mode_open`]. | |
| /// Obtained from [`crate::base_mode_seal::base_mode_seal`]. |
Comment on lines
+78
to
+81
| /// The id mappings are defined in in [RFC9180§7.2][1] and [draft-ietf-hpke-pq][2]. | ||
| /// | ||
| /// [1]: https://www.rfc-editor.org/rfc/rfc9180.html#section-7.2 | ||
| /// [2]: https://www.ietf.org/archive/id/draft-ietf-hpke-pq-05.html#table-1 |
Collaborator
There was a problem hiding this comment.
It might be better to reference https://www.iana.org/assignments/hpke/hpke.xhtml here.
Harmonize the configuration of `rustfmt` with other Divvi Up Rust projects by adding a `rustfmt.toml` using nightly-only options. - import grouping - wrap comments at 100 columns - error out if code exceeds 100 columns Also makes changes to appease the linter, as well as some manual changes to align with Rust RFC 1574 [1]. In order to use unstable `rustfmt` features, we must now use the nightly `cargo fmt` in CI. [1]: https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html
tgeoghegan
force-pushed
the
timg/normalize-comments
branch
from
July 13, 2026 18:13
0492a53 to
aec32f9
Compare
tgeoghegan
enabled auto-merge (squash)
July 13, 2026 18:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harmonize the configuration of
rustfmtwith other Divvi Up Rust projects by adding arustfmt.tomlusing nightly-only options.Also makes changes to appease the linter, as well as some manual changes to align with Rust RFC 1574 1.
In order to use unstable
rustfmtfeatures, we must now use the nightlycargo fmtin CI.