fix(imx296): correct fast-trigger frame delivery and PWM recovery#14
Open
OKayJH wants to merge 5 commits into
Open
fix(imx296): correct fast-trigger frame delivery and PWM recovery#14OKayJH wants to merge 5 commits into
OKayJH wants to merge 5 commits into
Conversation
Track fast-trigger mode across CIF so RKISP can identify IMX296. Finish V39 buffers at the last observable line. Delay vb2_done until tail DMA has drained. Restore full-frame ROI registers. Drain the invalid ROI frame during the free-run restart. Drop diagnostic and timing experiments from the production fix. Signed-off-by: OKayJH <okayjhh@gmail.com>
Cache the firmware PWM period instead of mutable runtime state. Recompute the period from the base period. Include the current pulse width and safety margin. Apply the disabled PWM state when trigger_pulse_us changes. This restores trigger rate after long-to-short exposure without reboot. Signed-off-by: OKayJH <okayjhh@gmail.com>
OKayJH
force-pushed
the
fix/imx296-fast-trigger-n1-pwm-period
branch
from
July 22, 2026 04:12
8f5e7c6 to
2c9b30b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YYYYMMDDNNDLCVCAM build identifier, visible on the build host and throughuname -von the boardProblem
After changing ROI in fast-trigger mode, the first captured result could correspond to frame N-1. Separately, a long exposure enlarged the PWM period, but returning to a short exposure reused that enlarged runtime period as the permanent baseline. The maximum trigger rate then remained around 20 fps instead of recovering to around 50 fps until reboot.
The previous release build number was supplied manually through
KBUILD_BUILD_VERSION, so the repository and delivered board could disagree. The newDLCVCAM_BUILD_VERSIONfile usesYYYYMMDDNN(currently2026072201) without changinguname -ror the kernel module directory.Validation
Image dtbs modulesbuild completed successfully6.1.99-rk3576 ... #2026072201 SMPmake -s dlcvcam-build-versionworks for source andO=builds; command-line override remains supported.versionremains unchanged during release builds