ci: add GitHub Actions CI for web and pipeline - #12
Merged
Conversation
The repo had no .github/workflows/, so nothing ran on PRs. Add a CI workflow with two jobs built from the project's real commands: - web: npm ci, npx tsc --noEmit (no typecheck script exists), vitest, eslint, next build — scoped to web/ via working-directory. - pipeline: pip install -r requirements.txt, pytest tests/ (190 tests, hermetic — render/network paths are mocked). soundfile bundles libsndfile in its wheel, so no apt step is needed. House style: name CI, push+PR to main, concurrency with cancel-in-progress, contents:read, pinned actions with dep caching. Validated with actionlint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repo had no
.github/workflows/, so no checks ran on any PR (including the recent ones — they merged and shipped on local verification alone). This adds a CI workflow with two jobs, each built from the project's own commands rather than invented ones.web— the Next app inweb/, scoped viaworking-directory:npm ci→npx tsc --noEmit(there is notypecheckscript, so tsc is called directly) →npm test(vitest) →npm run lint(eslint) →npm run build.pipeline— the Python corpus/generation pipeline at the repo root:pip install -r requirements.txt→pytest tests/. All 190 tests are hermetic (the render/network paths are mocked), so no Rack, Railway, or network access is needed.soundfilebundleslibsndfilein its wheel, so noaptstep is required.House style, consistent with the other repos:
name: CI, triggers on push + PR tomain,concurrencywithcancel-in-progress,permissions: contents: read,actions/checkout@v4, pinned setup actions with dependency caching.Generated (and dogfooded) by the new
repo-ciskill; validated withactionlint.Test plan
actionlint— cleanweb:npx tsc --noEmit,npm test(5/5),npm run lint,npm run buildall pass locallypipeline:pytest tests/— 190 passed in ~1.8s, no networkNote: consider adding this workflow as a required status check in
main's branch protection once it's proven green.