Skip to content

Issue #446: Admin JS broken after fresh install#451

Closed
alexmerlin wants to merge 28 commits into
7.0from
7.0-clean-packages
Closed

Issue #446: Admin JS broken after fresh install#451
alexmerlin wants to merge 28 commits into
7.0from
7.0-clean-packages

Conversation

@alexmerlin

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

Qodana for JS

1 new problem were found

Inspection name Severity Problems
Void function return value used 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@github-actions

Copy link
Copy Markdown

Qodana for JS

1 new problem were found

Inspection name Severity Problems
Void function return value used 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@alexmerlin alexmerlin linked an issue Jun 17, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 24.07407% with 41 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (7.0@856d76b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../Core/src/Security/src/Entity/OAuthAccessToken.php 0.00% 11 Missing ⚠️
src/Core/src/Security/src/Entity/OAuthAuthCode.php 0.00% 7 Missing ⚠️
src/Core/src/User/src/Entity/User.php 0.00% 5 Missing ⚠️
...rity/src/Repository/OAuthAccessTokenRepository.php 0.00% 4 Missing ⚠️
src/Core/src/Admin/src/Entity/Admin.php 40.00% 3 Missing ⚠️
...Core/src/Security/src/Entity/OAuthRefreshToken.php 0.00% 3 Missing ⚠️
...ecurity/src/Repository/OAuthAuthCodeRepository.php 0.00% 2 Missing ⚠️
.../Security/src/Repository/OAuthClientRepository.php 0.00% 2 Missing ⚠️
...ity/src/Repository/OAuthRefreshTokenRepository.php 0.00% 2 Missing ⚠️
...Core/src/App/src/Entity/NumericIdentifierTrait.php 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@          Coverage Diff           @@
##             7.0     #451   +/-   ##
======================================
  Coverage       ?   38.53%           
  Complexity     ?      925           
======================================
  Files          ?      169           
  Lines          ?     3768           
  Branches       ?        0           
======================================
  Hits           ?     1452           
  Misses         ?     2316           
  Partials       ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexmerlin

Copy link
Copy Markdown
Member Author

@GeorgeCatalinStan I made a couple of fixes/updates.
One last thing left to fix: opening a modal on the /admin/list-admin and /user/list-user pages fails without an error.

@alexmerlin

alexmerlin commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

@GeorgeCatalinStan Everything seems to be working as intended. 👍

I saw that you restored the jquery-sparkline and perfect-scrollbar packages.
Are they required by the app to function properly?

@alexmerlin alexmerlin force-pushed the 7.0-clean-packages branch from 10a5393 to 6159035 Compare June 18, 2026 04:06
@alexmerlin

Copy link
Copy Markdown
Member Author

@GeorgeCatalinStan

Please note that:

  • I updated your branch by merging branch 7.0 into it (bringing the Build Assets CI workflow for dependency checks)
  • I fixed the DCO check (signature)

Make sure that you update your local branch if you need to make further adjustments to this branch/PR.

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

Qodana for JS

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

SergiuBota1 and others added 21 commits June 19, 2026 10:52
Signed-off-by: bota <Bota@dotkernel.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: bota <Bota@dotkernel.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: bota <Bota@dotkernel.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: bota <Bota@dotkernel.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: bota <Bota@dotkernel.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: bota <Bota@dotkernel.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: bota <Bota@dotkernel.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: bota <Bota@dotkernel.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>

# Conflicts:
#	package.json
#	public/css/app.css
#	public/images/app/no-image.svg
#	public/js/admin.js
#	public/js/app.js
#	public/js/table_settings.js
#	public/js/user.js
#	src/App/assets/js/index.js
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
renovate Bot and others added 7 commits June 19, 2026 11:08
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
@alexmerlin alexmerlin force-pushed the 7.0-clean-packages branch from 1d145ae to a7fb8d5 Compare June 19, 2026 08:14
@alexmerlin

Copy link
Copy Markdown
Member Author

Closing in favor of #457 because I messed up this PR.

@alexmerlin alexmerlin closed this Jun 19, 2026
@alexmerlin alexmerlin deleted the 7.0-clean-packages branch June 19, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Admin JS broken after fresh install

3 participants