Move regenerate-native change detection into build.sh to match ClangSharp#272
Merged
tannergooding merged 1 commit intoJul 16, 2026
Merged
Conversation
…harp The detect job inlined its change-detection and package-version verification in YAML and referenced an unassigned `major_minor` in a diagnostic echo, which under `set -u` aborted the whole regenerate-native workflow. Mirror ClangSharp instead: the change-detection and version-verification logic now lives in scripts/build.sh as DetectChanges/VerifyPackages (invoked via --detectchanges --base <ref> and --verifypackages), so it is reproducible and testable locally, and the detect job just delegates to it. LLVMSharp keeps its genuine divergence of comparing the full patch version for libLLVM. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
tannergooding
force-pushed
the
fix-regenerate-native-major-minor
branch
from
July 16, 2026 06:02
0edf4f7 to
4027a4e
Compare
tannergooding
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
regenerate-nativedetectjob inlined its change-detection and package-version verification in YAML, and referenced an unassigned${major_minor}in a diagnosticecho:Under
set -euo pipefailthat aborts the whole workflow atdetectbefore any build/pack leg runs. It started failing on the push that landed the nativelibLLVMSharphelpers.Rather than just patch the stray variable, this converges on how ClangSharp handles the same job: the change-detection and version-verification logic moves into
scripts/build.shasDetectChanges/VerifyPackages(invoked via--detectchanges --base <ref>and--verifypackages), so it is reproducible and testable locally, and thedetectjob just delegates to it. Nomajor_minoranywhere.LLVMSharp keeps its one genuine divergence from ClangSharp: libLLVM regenerates on a change to the full patch LLVM version (e.g.
21.1.8), not major.minor, since the libLLVM package version tracks the full patch.Validated locally with git-bash:
--verifypackages->Package versions verified against LLVM 21.1.8--detectchangesreal branch ->libllvm=false libllvmsharp=false--base->libllvm=true libllvmsharp=true(conservative)libllvm=false libllvmsharp=true--base-> errors with exit 1bash -n scripts/build.shpasses; workflow YAML parses.Failing run: https://github.com/dotnet/LLVMSharp/actions/runs/29474949179/job/87545843218