[Mono.AndroidTools] Enable nullable reference types in AdbSyncNotification.cs#11778
Draft
Copilot wants to merge 2 commits into
Draft
[Mono.AndroidTools] Enable nullable reference types in AdbSyncNotification.cs#11778Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enable nullable reference types in AdbSyncNotification.cs
[Mono.AndroidTools] Enable nullable reference types in AdbSyncNotification.cs
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AdbSyncNotification.csships inMono.AndroidTools.dllbut compiled in a nullable-oblivious context. This opts the file into NRT, making its existing null contract explicit:LocalPathisnullfor directory/remove/preserve operations, whileRemotePathis always non-null.Changes
src/Mono.AndroidTools/Adb/AdbSyncNotification.cs#nullable enableas the first line.LocalPathproperty and thelocalPathconstructor parameter asstring?;RemotePathstays non-nullable.No null-throwing is required (
netstandard2.0, so noArgumentNullException.ThrowIfNull), and callers inAdbSyncContext.cs,AdbSyncClient.cs, andAndroidDevice.csare not nullable-enabled, so no call-site changes or warnings result.