Add BinaryWriter benchmarks for _useFastUtf8 true and false code paths#5121
Open
Copilot wants to merge 4 commits into
Open
Add BinaryWriter benchmarks for _useFastUtf8 true and false code paths#5121Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Co-authored-by: jeffhandley <1031940+jeffhandley@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Augment BinaryWriterTests benchmark coverage
Add BinaryWriter benchmarks for _useFastUtf8 true and false code paths
Feb 16, 2026
jeffhandley
requested changes
Feb 16, 2026
Co-authored-by: jeffhandley <1031940+jeffhandley@users.noreply.github.com>
jeffhandley
approved these changes
Feb 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional microbenchmarks for BinaryWriter to cover both UTF-8 and non-UTF-8 encoding paths, with new scenarios targeting Unicode (UTF-16) and non-ASCII input.
Changes:
- Expanded existing UTF-8 benchmarks to include non-ASCII
stringandchar[]inputs. - Added new
Encoding.Unicodebenchmarks to exercise non-UTF-8 code paths forWrite(string),Write(char[]), andWrite(char).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/benchmarks/micro/libraries/System.IO/BinaryWriterExtendedTests.cs |
Adds non-ASCII UTF-8 benchmarks and a new Encoding.Unicode benchmark class for string/char[] writes. |
src/benchmarks/micro/libraries/System.IO/BinaryWriterTests.cs |
Adds a new Encoding.Unicode benchmark class for Write(char). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+83
to
+86
| /// <summary> | ||
| /// Benchmarks for BinaryWriter with a non-UTF-8 encoding, exercising the | ||
| /// _useFastUtf8 = false code path for Write(char). | ||
| /// </summary> |
| [Benchmark] | ||
| public void WriteNonAsciiChar() | ||
| { | ||
| // '\u00E0' (à) encodes to 2 bytes in UTF-8, exercising multi-byte encoding paths |
Comment on lines
+64
to
+67
| /// <summary> | ||
| /// Benchmarks for BinaryWriter with a non-UTF-8 encoding, exercising the | ||
| /// _useFastUtf8 = false code path. | ||
| /// </summary> |
Comment on lines
+87
to
+88
| // '\u00E0' (à) encodes to 2 bytes in UTF-8, exercising multi-byte encoding paths | ||
| _nonAsciiInput = new string('\u00E0', StringLengthInChars); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_useFastUtf8condition in BinaryWriter (true for UTF-8 encoding, false for non-UTF-8)_useFastUtf8 = truepath via default UTF-8 encoding, ASCII only)_useFastUtf8 = trueand_useFastUtf8 = falsepathsBinaryWriterExtendedTests: AddedWriteNonAsciiCharArrayandWriteNonAsciiStringbenchmarks (UTF-8,_useFastUtf8 = truewith multi-byte chars)BinaryWriterUnicodeEncodingTests: New class usingEncoding.UnicodeforWrite(string)andWrite(char[])(_useFastUtf8 = false)BinaryWriterUnicodeEncodingCharTests: New class usingEncoding.UnicodeforWrite(char)(_useFastUtf8 = false)'\u00E0'character selection (2-byte UTF-8 encoding)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.