Refactor VectorSet to use Vector+Set instead of VectorMap#80
Merged
bishabosha merged 1 commit intoJul 17, 2026
Merged
Conversation
- Changed internal representation from VectorMap[A, Unit] to Vector[A] + Set[A] - This simplifies the implementation and provides better performance characteristics - Update tail/init to properly throw UnsupportedOperationException on empty set - Add early return for empty Iterable in from() method Update tests to cover all branches: - Add test for incl on empty set - Add test for knownSize on empty set - Add tests for tail/init throwing on empty set - Add test for VectorSet.from(VectorSet) identity case - Add test for VectorSet.from(empty Iterable) returning empty - Add test for builder clear() and result() on empty builder - Add test for SeqSet.from(SeqSet) identity case This change ensures 100% branch coverage of VectorSet implementation. LLM-assisted changes.
|
oh yeah thats much more obvious way to do it, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tests to cover all branches:
This change ensures 100% branch coverage of VectorSet implementation.