Conversation
…#1215) When pressing Enter to submit the modal, it stayed open during the API call. After addNewCue resolved it called loadCues(), which updated the store and briefly made isDuplicateNewCue true, showing a spurious warning before hide() finally closed the modal. Clicking OK was unaffected because BVN auto-closes the modal at the first await in the @ok handler, before loadCues() runs. Fix: move hide() to before the await so both paths close the modal immediately on valid submission. resetNewForm() is removed from here because the @hidden event already wires it as a cleanup handler. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
small-diff
|
Client V3 Test Results23 tests 23 ✅ 0s ⏱️ Results for commit 6c42041. |
Client Test Results128 tests 128 ✅ 0s ⏱️ Results for commit 6c42041. |
Python Test Results 1 files 1 suites 1m 47s ⏱️ Results for commit 6c42041. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.