Conversation
Adds a `line_position` column to `script_cue_association` to track the insertion order of individual cues and cue groups relative to each other on a line. Previously the frontend rendered individual cues first and groups second in two hardcoded loops, ignoring creation order entirely. - Backend: new `line_position` field on `CueAssociation`; POST handlers compute `max(existing) + 1` per line so each new cue/group gets the next position; GET includes `line_position` in the response - Migration: backfills existing data using `cue_id` as a creation-order proxy (individual cues get their cue_id; all members of a group share the `MIN(cue_id)` for that group) - Both clients: store getters now produce a merged sorted list; `ScriptLineViewer`, `ScriptLineViewerCompact`, and `ScriptLineCueEditor` in both Vue 3 and Vue 2 render a single loop over that list - 5 new backend tests covering I→G, G→I, G→I→G ordering, shared group position, and position stability after PATCH Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
client
Client V3 Test Results23 tests 23 ✅ 0s ⏱️ Results for commit afd2666. ♻️ This comment has been updated with latest results. |
Client Test Results128 tests 128 ✅ 0s ⏱️ Results for commit afd2666. ♻️ This comment has been updated with latest results. |
Bumps [python-jsonpath](https://github.com/jg-rp/python-jsonpath) from 2.0.2 to 2.1.0. - [Release notes](https://github.com/jg-rp/python-jsonpath/releases) - [Changelog](https://github.com/jg-rp/python-jsonpath/blob/main/CHANGELOG.md) - [Commits](jg-rp/python-jsonpath@v2.0.2...v2.1.0) --- updated-dependencies: - dependency-name: python-jsonpath dependency-version: 2.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [alembic](https://github.com/sqlalchemy/alembic) from 1.18.4 to 1.18.5. - [Release notes](https://github.com/sqlalchemy/alembic/releases) - [Changelog](https://github.com/sqlalchemy/alembic/blob/main/CHANGES) - [Commits](https://github.com/sqlalchemy/alembic/commits) --- updated-dependencies: - dependency-name: alembic dependency-version: 1.18.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.15.18 to 0.15.20. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.15.18...0.15.20) --- updated-dependencies: - dependency-name: ruff dependency-version: 0.15.20 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Python Test Results 1 files 1 suites 2m 4s ⏱️ Results for commit afd2666. ♻️ This comment has been updated with latest results. |
Playwright E2E Results (chromium)200 tests 200 ✅ 2m 5s ⏱️ Results for commit 2ec162e. |
Playwright E2E Results (firefox)200 tests 200 ✅ 2m 4s ⏱️ Results for commit 2ec162e. |
Resolves lint failures blocking the 0.34.0 release PR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.