Conversation
* Add admin-configurable JWT token lifetime setting
Expose a 'JWT Token Lifetime' dropdown in System Config → Security,
allowing admins to choose 1h/6h/12h/1d/1w/30d. Reducing the lifetime
takes effect immediately by checking the token's iat claim against the
configured maximum — any in-flight token older than the new limit is
rejected with HTTP 401, forcing re-login.
Extend SettingsObject with an optional choice_labels list so int-valued
options (e.g. 168, 720) show human-readable text in both frontend clients.
Add backend JWT age validation (jwt_service + base_controller + ws_controller),
integration tests, and Playwright E2E coverage for the Security settings panel.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix CI failures: E2E toast selector and password service word filter
- Use .v-toast__item selector in E2E test to avoid strict-mode violation
when two .v-toast container divs are present simultaneously
- Filter hyphenated words from EFF wordlist before generating passphrases;
four words (t-shirt, drop-down, yo-yo, felt-tip) caused split('-') to
produce more parts than expected, failing the word-count assertion
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix E2E race: wait for WS settings sync before restoring JWT lifetime
After submitting a settings change, the server broadcasts SETTINGS_CHANGED
via WebSocket which resets editSettings to match the new server state. If
we selectOption before that reset arrives, the WS update overwrites the
selection, leaving hasChanges=false and the Submit button permanently
disabled — causing the test to timeout.
Fix: after the first submit succeeds, wait for the Submit button to become
disabled (i.e. WS round-trip has settled and the form is back in sync)
before selecting the restore value.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…e key (#1271) The frontend read `.stage_direction_styles` from the GET response but the backend returns `{ "styles": [...] }`. The `?? []` fallback silently swallowed `undefined`, leaving `stageDirectionStyles` empty and permanently disabling the "New Override" button. Also adds E2E coverage for the full override creation flow in spec 14, and fixes a pre-existing strict-mode violation in the "About" tab test. "New Override" button locators are scoped to `#stage-directions-table thead` to avoid colliding with the same-named button in the Cue Colour Preferences tab (BVN BTabs without `lazy` keeps all tab panels in the DOM). Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
documentation
Client V3 Test Results23 tests 23 ✅ 0s ⏱️ Results for commit 050cf3d. ♻️ This comment has been updated with latest results. |
Client Test Results128 tests 128 ✅ 0s ⏱️ Results for commit 050cf3d. ♻️ This comment has been updated with latest results. |
Python Test Results 1 files 1 suites 2m 6s ⏱️ Results for commit 050cf3d. ♻️ This comment has been updated with latest results. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.