Skip to content

Sync fork from upstream openconfig/kne (resolve conflicts)#29

Closed
msupinodn wants to merge 6 commits into
mainfrom
sync-fork-resolved
Closed

Sync fork from upstream openconfig/kne (resolve conflicts)#29
msupinodn wants to merge 6 commits into
mainfrom
sync-fork-resolved

Conversation

@msupinodn

Copy link
Copy Markdown
Collaborator

This supersedes #28, whose head was upstream openconfig/kne:main (maintainerCanModify=false) and therefore could not be updated, so the resolved merge is pushed here as a replacement branch.

What this pulls from upstream openconfig/kne

Conflict resolution

  • go.mod/go.sum: kept the fork newer grpc v1.79.3 / protobuf v1.36.10
  • Preserved all DriveNets customizations: drivenets node type, cdnos/meshnet manifests, fork CI
  • Resolved as commit e4b1e90

Build/test

  • Builds clean (go build ./... for all buildable packages)
  • Touched-package tests pass

jasdeep-hundal and others added 6 commits March 18, 2026 08:55
* Upgrade k8s to 1.35

* cloud-provider-gcp no longer uses Bazel build

* Set go path for auth-provider-gcp build
* configure containerd mirror for registry.k8s.io

* update path for internal

* fix config path

* enable authentication for kubelet containerd mirrors

* use kne-external for infra containers

---------

Co-authored-by: Neha Manjunath <nehamanjunath@google.com>
* update srlinux controller manifest

* bump srl-controller
* Add support for IN_CLUSTER_PROXY node type
- Update proto/topo.proto with `IN_CLUSTER_PROXY` in Vendor and `Node.Type` enums.
- Create `topo/node/inclusterproxy` package implementing `Node` interface.
- Set default image to `nicolaka/netshoot:latest` and enforce at least 1 `Service`.
- Enforce link constraints to allow exactly one interface (`eth1`).
- Add warning if `socat` is missing from `Command` or `Args`.
- Update `topo/topo.go` to register the new node type.
- Add unit tests in `topo/node/inclusterproxy/inclusterproxy_test.go`.

* Add support for IN_CLUSTER_PROXY node type
- Update proto/topo.proto with `IN_CLUSTER_PROXY` in Vendor and `Node.Type` enums.
- Create `topo/node/inclusterproxy` package implementing `Node` interface.
- Set default image to `nicolaka/netshoot:latest` and enforce at least 1 `Service`.
- Enforce link constraints to allow exactly one interface (`eth1`).
- Enforce that `proxy-pool-for` label is present in static configuration.
- Add static validation assuring `eth1` is connected directly to the node given in `proxy-pool-for`.
- Add automatic `socat` command generation using `peer-ip` and `target-port` labels:
    - Supports IPv4 address allocation arithmetic using `/31` masks.
    - Adds IPv6 support using `/127` arithmetic and handles `TCP6-LISTEN` argument switches.
- Update `topo/topo.go` to register the new node type.
- Update `topo/topo.go` to register the new node type.
- Add unit tests in `topo/node/inclusterproxy/inclusterproxy_test.go`.

* Fix config labels for peer ip

* Rename calculateStaticIP to deriveAdjacentIP

* Fix typos

* Fix failing valid_pb_with_automatic_generation_ipv

* Fix lint errors
)

* Relax IN_CLUSTER_PROXY link validation to support
early addDefaults() passes

When loading KNE topologies via the Ondatra testbed framework (knegcebind),
an early `addDefaults()` pass instantiates nodes via `node.New()` to
calculate default values. Since this pass occurs before the KNE topology
manager has fully resolved cross-node links, `eth1.PeerName` is empty
during initialization.

* Relax IN_CLUSTER_PROXY link validation to support
early addDefaults() passes

When loading KNE topologies via the Ondatra testbed framework (knegcebind),
an early `addDefaults()` pass instantiates nodes via `node.New()` to
calculate default values. Since this pass occurs before the KNE topology
manager has fully resolved cross-node links, `eth1.PeerName` is empty
during initialization.
… containerd mirrors, proto/topo)

Resolved go.mod/go.sum conflicts by keeping the DriveNets fork's newer
security-bumped versions (grpc v1.79.3, protobuf v1.36.10) over upstream's
older protobuf v1.36.7 / grpc v1.65.0, then ran 'go mod tidy'. All other
upstream dependency bumps and the 10 non-conflicting files auto-merged.

Co-authored-by: Cursor <cursoragent@cursor.com>
@msupinodn msupinodn mentioned this pull request Jun 15, 2026
@msupinodn msupinodn closed this Jun 15, 2026
@msupinodn msupinodn deleted the sync-fork-resolved branch June 15, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants