Fix JSON-RPC notification responses#267
Open
GhostStar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idmember is absentid: nulldistinct and return a valid response for itRoot cause
viem sends this notification every 30 seconds as its WebSocket keepalive:
{"jsonrpc":"2.0","method":"net_version","params":[]}NodeCore mapped the missing client ID to an empty byte slice and serialized a response as:
{"id":,"jsonrpc":"2.0","result":"4663"}That invalid frame makes viem fail JSON parsing and close the shared subscription socket. JSON-RPC 2.0 notifications must not receive a response.
Tests
go test ./internal/server/http_server -count=1make buildThe full suite passes except for the pre-existing timing-sensitive
TestEngineSlowConsumerDoesNotAffectFastPeerwhen run under full-suite load; it passes independently for 3 consecutive runs.