feat: Starknet family support (starknet, starknet-sepolia)#285
Open
artemrootman wants to merge 4 commits into
Open
feat: Starknet family support (starknet, starknet-sepolia)#285artemrootman wants to merge 4 commits into
artemrootman wants to merge 4 commits into
Conversation
Fixes the half-registered state where a starknet upstream died with "no method spec with name ''" - the BlockchainType existed but nothing else. - starknet_specific: poll-based latest head via getBlockWithTxHashes (dshackle parity), poll-only (spec-v0.8 WS is a follow-up). - starknet_validations: real chain-id validation via starknet_chainId (dshackle hardcodes the response and validates nothing) and syncing health handling all three result forms (false/true/sync object, hex or numeric block fields, lag threshold). - starknet_labels: two-probe client identity (pathfinder_version -> juno_version fallback) as a direct LabelsDetector implementation. - starknet_bounds: verified-archive bound - probes block 1 and emits STATE/BLOCK=1 only on success (dshackle hardcodes 1 blindly); pruned nodes fall back to UnknownBound with a logged follow-up. - starknet method spec: the 25-method dshackle-parity surface, not-null dispatch on block/tx reads and the three add*Transaction submits - NOT broadcast: starknet returns DUPLICATE_TX=59 on identical resubmission, fan-out would manufacture errors (the very reason dshackle's broadcast is broken there). - registry: getMethodSpecName starknet case + factory case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the Starknet blockchain family (
BlockchainType = "starknet"). Also fixes the current half-registered state where a configured starknet upstream fails at startup withno method spec with name ''.Design doc:
docs/superpowers/specs/2026-07-17-starknet-support-design.md.Stacked on #284 (ripple family); will retarget as the stack merges.
How
The most standard family so far — plain JSON-RPC 2.0, no envelope quirks, no translations:
starknet_specific: poll-based latest head viastarknet_getBlockWithTxHashes("latest"); poll-only (spec-v0.8 WS subscriptions are a follow-up).starknet_validations: real chain-id validation viastarknet_chainId(dshackle hardcodes the response and validates nothing) — the hex-felt values (SN_MAIN/SN_SEPOLIA) already live inchains.yaml; syncing health handles all three result forms (bare false/true and the sync object with hex-or-numeric block fields) with the lag threshold.starknet_labels: two-probe client identity (pathfinder_version→juno_versionfallback) as a directLabelsDetectorimplementation.starknet_bounds: verified-archive bound — probes block 1 and emits STATE/BLOCK=1 only on success (dshackle hardcodes 1 blindly, which misroutes against pruned nodes); pruned nodes fall back to UnknownBound.not-nulldispatch on block/tx reads and the threeadd*Transactionsubmits — deliberately not broadcast: starknet answers identical resubmission withDUPLICATE_TX=59(an error, unlike EVM's success echo), so fan-out manufactures errors; this is the very reason dshackle's starknet broadcast is broken ("fix broadcast on starknet" TODO).Testing
juno_versionis internal-only, matching dshackle). Mainnet corpus impossible today (no node deployed);SN_MAINcovered by unit tests. Details in the design doc.