feat(meridian): chore-replace-panic-with-typed-errors-in-router- - #435
feat(meridian): chore-replace-panic-with-typed-errors-in-router-#435Caneryy wants to merge 1 commit into
Conversation
|
@Caneryy is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Caneryy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
collinsezedike
left a comment
There was a problem hiding this comment.
CI is failing on two things:
Commit Messages: header is 73 characters, over the 72-char limit. Needs shortening, e.g.chore(contracts): replace panic! with typed errors.Soroban Contract Tests:cargo fmt --all -- --checkfails on the import block inblend-adapter/src/lib.rs. Runcargo fmtand push the result.
The PR title (feat(meridian): chore-replace-panic-with-typed-errors-in-router-) also needs fixing to match, since this repo squash-merges using the PR title as the commit message.
The implementation itself is correct, I ran the full test suite and clippy locally and both pass clean. Just these two fixed before merge.
|
This PR's body doesn't follow CONTRIBUTING.md's PR body format (see "Pull Request Process" > "PR body format"). The Summary section should describe what changed and why, not restate the issue title. The Test plan checkboxes should be checked once you've actually run Please update the PR body to reflect what you actually did and verified before this is merged. |
Closes #433
Summary
Test plan