Skip to content

ci: wire verify-contracts into CI and add rounding edge case tests - #440

Open
Onyii1234 wants to merge 1 commit into
drydocs:mainfrom
Onyii1234:ci/verify-contracts-and-rounding-tests
Open

ci: wire verify-contracts into CI and add rounding edge case tests#440
Onyii1234 wants to merge 1 commit into
drydocs:mainfrom
Onyii1234:ci/verify-contracts-and-rounding-tests

Conversation

@Onyii1234

Copy link
Copy Markdown
  • [Chore] Wire verify-contract-addresses.ts into CI #431: add verify-contracts CI job to ci.yml

    • uses dorny/paths-filter@v3 to gate on constants.ts / known-pools.ts
    • installs Stellar CLI and wasm32v1-none target (matching script's expected build path)
    • delegates retry logic to the existing retry() in the script itself
    • job is required/blocking; skips expensive steps on unrelated PRs
  • [Test] Add coverage for DepositTooSmall and WithdrawalTooSmall rounding edge cases #434: add DepositTooSmall and WithdrawalTooSmall test coverage

    • deposit_too_small_fails: seeds 1-stroop deposit, inflates share price via direct adapter donation, asserts 1-stroop deposit returns ContractError::DepositTooSmall
    • withdrawal_too_small_fails: seeds 1-stroop deposit, drains adapter balance to zero, asserts withdrawal returns ContractError::WithdrawalTooSmall
    • cargo test -p meridian-vault: 26/26 pass

Summary

Test plan

  • pnpm lint && pnpm typecheck && pnpm test pass locally
  • [ ]

Closes #431
closes #434

- drydocs#431: add verify-contracts CI job to ci.yml
  - uses dorny/paths-filter@v3 to gate on constants.ts / known-pools.ts
  - installs Stellar CLI and wasm32v1-none target (matching script's
    expected build path)
  - delegates retry logic to the existing retry() in the script itself
  - job is required/blocking; skips expensive steps on unrelated PRs

- drydocs#434: add DepositTooSmall and WithdrawalTooSmall test coverage
  - deposit_too_small_fails: seeds 1-stroop deposit, inflates share
    price via direct adapter donation, asserts 1-stroop deposit returns
    ContractError::DepositTooSmall
  - withdrawal_too_small_fails: seeds 1-stroop deposit, drains adapter
    balance to zero, asserts withdrawal returns
    ContractError::WithdrawalTooSmall
  - cargo test -p meridian-vault: 26/26 pass
@vercel

vercel Bot commented Jul 26, 2026

Copy link
Copy Markdown

@Onyii1234 is attempting to deploy a commit to the Collins' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jul 26, 2026

Copy link
Copy Markdown

@Onyii1234 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@collinsezedike collinsezedike left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be split into two PRs before it can be reviewed further. Please read CONTRIBUTING.md, specifically the "Pull Request Process" section, rule 1: "One PR per issue. Do not bundle multiple issues into a single PR." This one closes both #431 and #434 with unrelated changes, a CI workflow job and Rust contract tests. Please open one PR for each.

CI is also failing: cargo fmt --check fails on a missing trailing newline at the end of vault/src/lib.rs. Run cargo fmt and push the result.

The PR body's ## Summary and ## Test plan sections are empty, the actual template placeholders are still there unfilled. Please also read the "PR body format" section of CONTRIBUTING.md, the content you wrote above the template is detailed and useful, it just needs to go in the right place.

The underlying work in both changes looks solid otherwise, the CI job is correctly scoped and the rounding tests are well-reasoned. Once split, fixed, and the body filled in properly, this should move quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test] Add coverage for DepositTooSmall and WithdrawalTooSmall rounding edge cases [Chore] Wire verify-contract-addresses.ts into CI

2 participants